uilist now draws selected row without color #76346
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Info / User Interface
|
Build errors fixed in #76349 |
db48x
force-pushed
the
no-color-in-active-menu-item
branch
from
7a0ba64
to
d39d60e
Compare
This eliminates problems with contrast between the foreground colors in the text and the background color used to indicate which row is selected. Fixes CleverRaven#75974
db48x
force-pushed
the
no-color-in-active-menu-item
branch
from
d39d60e
to
8538108
Compare
|
I fixed the merge conflict; now let’s wait and see if the spurious test failure went away as well. |
github-actions
bot
added
the
BasicBuildPassed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Interface "improve contrast in uilist menus by not allowing colored text in highlighted menu items"
Purpose of change
Fixes #75974
Describe the solution
Just remove color tags from the string (caching the results so it only has to be done once per menu item) and then choose between colored or uncolored text as appropriate.
Describe alternatives you've considered
Just not.
Testing
Start at the main menu and load a game. The menu to choose a character uses color in the menu item text, so you can see right away how it works. Most other menus don’t use color like this.