Debug menu: dialogue menu + talk_topic menu #80705
Annotations
5 errors
|
run clang-tidy:
src/npctalk.cpp#L1372
the parameter 'debug_topic' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
|
|
run clang-tidy:
src/npctalk.cpp#L1375
the 'empty' method should be used to check for emptiness instead of 'size' [readability-container-size-empty,-warnings-as-errors]
|
|
run clang-tidy:
src/npctalk.cpp#L7676
return type 'const std::vector<std::string>' (aka 'const vector<basic_string<char>>') is 'const'-qualified at the top level, which may reduce code readability without improving const correctness [readability-const-return-type,-warnings-as-errors]
|
|
run clang-tidy:
src/npctalk.cpp#L7680
'push_back' is called inside a loop; consider pre-allocating the container capacity before the loop [performance-inefficient-vector-operation,-warnings-as-errors]
|
|
run clang-tidy
Process completed with exit code 123.
|
Loading