Fix/gps throttle message #51
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the PR! I think we can set it to a large value like every minute or even larger by default. This was basically only for me to see if switching on GPS works reliably. |
|
I set it up by default to 60s |
olliewalsh
requested changes
Oct 13, 2023
| @@ -434,15 +434,15 @@ void checkSafety(const ros::TimerEvent &timer_event) { | |||
| // set this if we don't even have an orientation | |||
| high_level_status.gps_quality_percent = -1; | |||
| } | |||
| ROS_WARN_STREAM_THROTTLE(1,"Low quality GPS"); | |||
| ROS_WARN_STREAM_THROTTLE(last_config.gps_message_throttle,"Low quality GPS"); | |||
There was a problem hiding this comment.
Could leave it as it but just not log it when !currentBehavior->needs_gps())?
|
I have merged the xbot_positioning PR. I agree with olliewalsh that we should only print it, when GPS is actually needed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This goes along with ClemensElflein/xbot_positioning#3 to reduce the amount of gps messages when not needed.