Clam 2646 update recipes #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Curl has an option to use libidn2 in version 8.9.0. Pkg-config may unexpectedly find it and use it. I encountered this on Windows because libidn2 was installed by Strawberry Perl, under C:\Strawberry. Pkg-config found that and tried to build it into Curl, which is problematic in part because we don't want to include or ship libidn2 with our software. But also problematic because libidn2 provided by Strawberry Perl used a different OpenSSL incompatible with the one we're compiling against. This commit explicitly disables pkg-config and libidn2 for libcurl builds. TODO: Perhaps disable pkg-config for all recipes and all platforms? Mussels builds should only draw from other mussels include/lib files.
nghttp2 -> 1.63.0 libxml2 -> 2.13.3
micahsnyder
force-pushed
the
CLAM-2646-update-recipes
branch
8 times, most recently
from
9a3cc37
to
9a9c493
Compare
Because of possible linking path issues
micahsnyder
force-pushed
the
CLAM-2646-update-recipes
branch
2 times, most recently
from
c452e72
to
d77c83c
Compare
Xcode dropped support for 'buildsystem=1' option. Disable building docs on unix systems and ensure only building library. The docs build is what was failing the Xcode "new build system" build.
micahsnyder
force-pushed
the
CLAM-2646-update-recipes
branch
from
d77c83c
to
05f4d0a
Compare
Automatic library detection finds brew-installed libs. This is primarily to fix builds on GitHub Actions where the system provides all sorts of stuff we didn't request. On macOS, specifically, this causes failures because we build universal binaries, and brew binaries are not universal and lack symbols for othe other platform.
It seems like we're detecting system-provided headers. If the system headers differ from our lib, we may end up with 'missing' symbols. This is to fix a build issue on macOS in GitHub Actions.
micahsnyder
force-pushed
the
CLAM-2646-update-recipes
branch
from
212f0eb
to
ecd619b
Compare
csbg-draynor
approved these changes
Sep 2, 2024
TheRaynMan
approved these changes
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump versions for nghttp2, libxml2
nghttp2 -> 1.63.0
libxml2 -> 2.13.3
Also:
libcurl, Windows: disable libidn2 disable pkg-config
Curl has an option to use libidn2 in version 8.9.0.
Pkg-config may unexpectedly find it and use it.
I encountered this on Windows because libidn2 was installed by
Strawberry Perl, under C:\Strawberry. Pkg-config found that and tried to
build it into Curl, which is problematic in part because we don't want
to include or ship libidn2 with our software.
But also problematic because libidn2 provided by Strawberry Perl used a
different OpenSSL incompatible with the one we're compiling against.
This commit explicitly disables pkg-config and libidn2 for libcurl
builds.
TODO: Perhaps disable pkg-config for all recipes and all platforms?
Mussels builds should only draw from other mussels include/lib files.
Note: This PR now replaces libcurl, Windows: disable libidn2 disable pkg-config #62
libcurl, Windows: copy DLL from bin to lib, instead of move
Because of possible linking path issues
libnghttp2, macOS: fix compat issue with newer Xcode
Xcode dropped support for 'buildsystem=1' option.
This issue was discovered while developing GitHub Actions workflows to test changes to the recipes. It seems GitHub's macOS runner has newer XCode than our internal Mac build host.
Disable building docs on unix systems and ensure only building library.
The docs build is what was failing the Xcode "new build system" build.
Add GitHub Workflows to test changes