Skip to content
This repository has been archived by the owner on Feb 8, 2024. It is now read-only.

Scheduled pipelines improvements #104

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

blag
Copy link

@blag blag commented Nov 11, 2021

This PR fixes a few small things:

  • A Markdown syntax omission
  • Indent the code blocks so they render at the same indent depth as the list items in which they appear

It also improves the conversion examples by also including the branch filtering criteria, converted to workflow filtering syntax.

Previously the converted examples did not include workflow filtering for the branch filtering present in the previous trigger syntax:

      daily-run-workflow:
        triggers:
          - schedule:
              # Every day, 0421Z.
              cron: "21 4 * * *"
              filters:      # <--
                branches:   # <--
                  only:     # <--
                    - main  # <-- These parts

Reviewers please pay special attention to the last example, because I'm not 100% sure if this is supported filtering syntax:

when:
  and:
    - not:
        equal: [ scheduled_pipeline, << pipeline.trigger_source >> ]
    - equal: [ "main", << pipeline.git.branch >> ]

If I have missed the detailed documentation on the when and unless clauses, please point me to them.

Edit: Completeness and grammar.

@blag
Copy link
Author

blag commented Jul 11, 2022

Is this getting merged anytime soon?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants