Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: Sound mixer auto reset #2856

Closed
wants to merge 4 commits into from
Closed

FIX: Sound mixer auto reset #2856

wants to merge 4 commits into from

Conversation

MyDrift-user
Copy link
Contributor

@MyDrift-user MyDrift-user commented Oct 1, 2024 •
edited
Loading

Type of Change

  • New feature

Description

  • fix issue nonrelated to microwin but windows itself since at least 9 years , duh.
    • add reg addition of key to make sound mixer work
      • Here is the link to the reddit post about it from r/christitustech
  • remove unused var definitions (from removed Microwin Options)

Testing

  • test worked for others, but you have to restart twice for it to save the application volume correctly like explained in reddit thread.

Issue related to PR

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no errors/warnings/merge conflicts.

@MyDrift-user
remove unused variables
97708f7 
- remove unused var definitions
- add reg addition of key to make sound mixer work
@MyDrift-user
Merge branch 'ChrisTitusTech:main' into MWSoundmixerfix
e1651aa
@MyDrift-user MyDrift-user marked this pull request as ready for review October 1, 2024 14:29
ChrisTitusTech
ChrisTitusTech requested changes Oct 1, 2024
View reviewed changes
Copy link
Owner

@ChrisTitusTech ChrisTitusTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to load the HKCU Hive using a reg load command

Right now only HKLM is being loaded and can be changed.

Once this is done we should be able to do a command like reg add "HKCU/zSoftware..."

@CodingWonders
Copy link
Contributor

It's already fixed, @ChrisTitusTech

@MyDrift-user MyDrift-user marked this pull request as draft October 2, 2024 07:25
CodingWonders added a commit to CodingWonders/winutil that referenced this pull request Oct 6, 2024
@CodingWonders
Fix Volume Mixer issues and removal of leftovers
62b1ec1 
Fix originally from @MyDrift-user on ChrisTitusTech#2856
@belthesar belthesar mentioned this pull request Oct 7, 2024
Open
@CodingWonders CodingWonders mentioned this pull request Oct 7, 2024
Merged
8 tasks
@MyDrift-user
Copy link
Contributor Author

This change is now included in the linked anniversary PR by @CodingWonders, so I will be closing this.

ChrisTitusTech pushed a commit that referenced this pull request Oct 7, 2024
@CodingWonders @og-mrk
[MicroWin] First Anniversary Special PR (#2853)
1404efa 
* Fix minor denomination problem for packages

* Fix incorrect filter of OS packages

Packages such as the metadata for capabilities (FoDs) or the foundation package were being incorrectly filtered. They were part of `Remove-ProvisionedPackages`, which only removes AppX packages. These are **OS packages**, something completely different

* Fixed indentation

* Exclude `Microsoft-RemoteDesktopConnection`

Exclude that from feature list. Fixes #2705

* Remove DISM from AppX removal listings

DISM is a system component. It will never be an AppX package. This is unnecessary

* Improve error handling for file copy

* Remove space (for some reason)

Compilation script is very adamant that this should be this way

* Exclude the VBSCRIPT Features on Demand from pkgs

Exclude the VBSCRIPT feature on demand (or capability) from package removal. Some people were reporting that excluding VBSCRIPT fixed problems with AMD chipset drivers on MicroWin

* Exclude Recall from feature listings

This fixes problems people were experiencing where the file explorer would go back to the Windows 10 layout

* Improve error output

* Add 24H2 to release list

* Detect Windows 10 and show compatibility dialog

* Disable some insane desktop stuff on Windows 10

I've only been able to disable Search Highlights. News and Interests persists

* Change policy for News and Interests

Avoid showing "Access denied" errors for this. This is still broken - News and Interests is still there. [louder]Linus Torvalds curse word here[/louder]

Anyway, if someone wants to give setting this up a shot, send me suggestions on how to do this

* Write suggestion for AV

* Hold errored packages in a list

Items are being added correctly, but I can't get that to show to the end-user. Perhaps a different approach will work

* Remove older Windows versions from download list

Sadly, the links for these had been removed by Microsoft, in favor of the latest version (24H2)

* Add sorting to error messages

Thanks @og-mrk for the suggestion and the patch (even though I applied it myself)

* Make error messages easier to view (#1)

* Make error messages easier to view

* Improve error output

---------

Co-authored-by: CodingWonders <[email protected]>

* Disable Recall on first run

Keeps the Explorer look of modern Windows 11 builds whilst removing the Recall feature (which I think will manifest itself on PCs with Lunar Lake processors)

* Replace "C:\" with environment variable

This still works on single-boot configurations, but presents a more dynamic approach

* Fix Volume Mixer issues and removal of leftovers

Fix originally from @MyDrift-user on #2856

* Add missing piece to last commit

* Default to downloading OSCDIMG from GitHub repo

Chocolatey may not be the way to help us detect the presence of OSCDIMG.

Everyone, unless someone REALLY uses old deployment technology, has moved to Windows ADK 10.0

* Fix Sorting of Errored Packages by using 'Sort-Object' instead of 'IComparer' approach (#2)

Fixes startup issues in PWSH 7

* Remove reference to News and Interests from output

Even though the logic is still there, it doesn't work. I don't want to deal with that anymore. Search Highlights, on the other hand, is removed very easily

* Exclude License packages from removal

They throw an "Access denied" error when trying to remove them. This is a timesaver

---------

Co-authored-by: Mr.k <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CodingWonders CodingWonders CodingWonders requested changes

@ChrisTitusTech ChrisTitusTech ChrisTitusTech requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sound mixer settings keeps resetting [MicroWin] Sound precentage resets itself every time.
3 participants
@MyDrift-user @CodingWonders @ChrisTitusTech