Add logic to remove Registry Keys via Tweaks #2837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Idk, maybe we should generally improve the contribution guide (in another PR), like mention the templated way of doing reg changes, task changes, service changes, explain invokescript and undoscript and so one.. |
ChrisTitusTech
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Adds the option to specify "" as a Registry Value in the tweaks.json registry definition.
When this is provided, the value will be fully removed instead of simply being set to a specific value.
Testing
Tested this on a demo Tweak and it seemed to work.
Impact
This should not affect anything except when the Registry value is explicitly set to
Issue related to PR
Additional Information
@MyDrift-user I have no clue where to put this in the documentation. Maybe you can give me a hint on where to mention this "feature"