Fix Dark Color Scheme #2788
Merged
Fix Dark Color Scheme #2788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I feel like tha background could be a bit darker than this. |
It's actually the same as it is in the current stable release |
|
Yeah ik I meant that, maybe not as dark as current main branch but a bit darker |
|
Let's leave the final design to our best maintainer :D |
|
Oh this broke again. |
|
@Marterich for color reference you can look youtube dark mode. or this #13171b color is also good for background |
|
DNS Button color also broke |
|
It is the "Comboboxforegroundcolor" is used in many places, which is ducked up |
Rly? Haven't seen it anywhere else while taking a quick peek |
|
i think we need to document what goes where for future ease. |
ChrisTitusTech
approved these changes
Sep 23, 2024
Real-MullaC
pushed a commit
to Real-MullaC/winutil
that referenced
this pull request
Sep 29, 2024
* fixes the ComboBoxForegroundColor to be more easily readable on dark mode * Fix Background * Change DNS Dropdown to Button Color
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Most likely some of the Changes to the Theme were broken during some of the last commits, so here's my two cents on how to fix it (without actually taking the time and checking what settings were used before)