[CI/CD] WIP: Re-use Workflows to Ensure GitHub Pages is built after every pre-release - Cleanup Workflow Naming Inconsistency - Remove 'release.yaml' workflow #2471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rrent branch Current branch means the running git branch that the GitHub Action was ran at.
og-mrk
force-pushed
the
workflow-update/fix-createchangelog-not-running
branch
from
1656a89
to
3f66851
Compare
og-mrk
force-pushed
the
workflow-update/fix-createchangelog-not-running
branch
2 times, most recently
from
77da72d
to
2d95b12
Compare
og-mrk
changed the title
og-mrk
changed the title
og-mrk
force-pushed
the
workflow-update/fix-createchangelog-not-running
branch
from
e710423
to
78e1487
Compare
og-mrk
force-pushed
the
workflow-update/fix-createchangelog-not-running
branch
from
78e1487
to
6c5c869
Compare
og-mrk
force-pushed
the
workflow-update/fix-createchangelog-not-running
branch
from
58986e9
to
753d9f9
Compare
og-mrk
force-pushed
the
workflow-update/fix-createchangelog-not-running
branch
from
822a92d
to
0d12b0c
Compare
og-mrk
force-pushed
the
workflow-update/fix-createchangelog-not-running
branch
from
0dfbeaa
to
c26bced
Compare
…here Found' step in 'close-discussion' workflow
og-mrk
force-pushed
the
workflow-update/fix-createchangelog-not-running
branch
from
c26bced
to
416ab76
Compare
og-mrk
force-pushed
the
workflow-update/fix-createchangelog-not-running
branch
from
6178f3d
to
51e13fa
Compare
See commit patches, or try running this workflow, and see its output.
…rstandable by Markdown - 'createchangelog' Workflow
og-mrk
force-pushed
the
workflow-update/fix-createchangelog-not-running
branch
from
5e6e21f
to
1982579
Compare
|
could you maybe if PR #2481 gets merged first change the logics to first run the docs script, then build the docs page and in the end do the release? |
Sure thing @MyDrift-user, I'll make sure to test it as well 👍 |
6 tasks
|
Make sure this also includes pre releases but make sure in docs it looks like a normal release to cause no issues in WinUtil. |
|
You are doing too much with this PR... Changing the names should be its own PR. That way we can easily see what changes with the workflows. I will close this in it's current state. |
4 tasks
|
Don't like the change in file name extensions as I can't analyze the difference between them well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
This PR Fixes the
close=discussionworkflow not working in specific edge cases (when there's no linking to any issue or discussion, bash will crash 😅, see commit 416ab76 for the fix), and fixescreatechangelogworkflow which won't work in specific instances, like when you edit/delete a release, or when main branch is updated (something to do withactions/checkoutaction, plus how GitHub gives triggered Workflows theirref& the derivedref_namegithub environments/built-ins).Besides simple fixes highlighted above, it also tries to make future deployments of winutil easier, by making use of GitHub Actions Reusable Workflows, now you can run a single workflow that'll call another workflow, and so on (up until three-layers deep (4 including the triggered workflow), source).
Diagram
Testing
As shown in latest run using these changes (link to it), it works as intended.
Fixes to
close-discussioncan be seen in PR og-mrk#27 & its run (when the author of PR doesn't specify any issues/discussions), plus PR og-mrk#28 & its run (fails because the IDs given are either not valid (not found in current repo) or simply doesn't exist, or it isn't a discussion (maybe an issue)).The fix for
createchangelogworkflow is coming soon...Impact
Makes sure that the Changelog is up-to-date with every release.
Checklist