Add a few improvements #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update setup.sh to be more bash like.
add xdg folders export linuxtoolboxdir as other scripts will use it add caching for starship and zoxide so that the shell starts faster
Add installation guide for people who don't know how to install it
I by mistake left in some of the echo debugging while I was working on the script. So i removed it
ChrisTitusTech
approved these changes
Jul 14, 2024
|
Love the additions, modified it further to switch from bash to sh for speed and POSIX compliance. Thanks @Subarctic2796 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Chris love your videos.
README changes
I added install instructions to the README.
setup.sh changes
I have started working on making the setup.sh script follow bash standards more. (such as adding
local varnameinstead ofvarname, and using arrays instead of splitting. Everything that I did is documented in the comments that I added to the script. I am just following stuff from https://github.com/bahamas10/bash-style-guide.bashrc changes
I also added a few of the XDG folders to the exports in the .bashrc file, I have also exported the
LINUXTOOLBOXDIRas an environment variable as that is going to be used in the linutil and I assume other scripts you make in the future, so this will just make it easier to do stuff. I also added caching for starship and zoxide (basically I am just putting the init scripts into a file and sourcing it) I have found that doing this speeds up the shells startup time.