-
Notifications
You must be signed in to change notification settings - Fork 671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First Pass At an FSharp Koan for Type Providers Resolving #77 #79
base: fsharp
Are you sure you want to change the base?
Conversation
I've always thought that a koan for type providers would be nice, but I thought it would be hard to come up with a clean way to fit the format. However, I really like the direction this is headed in, and I think it could be a clean way to integrate type providers with the koans. I have a few suggestions if you're interested in doing a little extra work on this.
Either way, thanks so much for this contribution. It looks like a great idea! |
I agree with all of your points.
Let me see what I can cook up. |
For 2, I think just a comment referencing the fact that there are additional types of type providers is sufficient. I agree that putting in a full SqlClient is a bit too much overhead. Just something to get the user thinking about other options sounds good to me. For 3, I think it's fine to use the same data as the other koan. You could even remix the prompt from the problem to have the user solve a problem with the data using a type provider. If you do that, I'd start with a couple easy "fill in the blank" koans leading up to the open-ended problem. For 4, I would put this koan last, especially if you go with the idea of using a more open-ended prompt above. |
…xclusions for local files
…lusions for local files
Ugh... Looks like I wound up committing a bunch of items I didn't intend to commit here. :-/ Let me go clean that up. |
@ChrisMarinos ok, this looks like it is now actually ready to be reviewed again - I think. Apologies for the messy interrupts in there. Hopefully squashing commits will take out the messy stops/starts for the final merge into the main branch? |
Thanks for the update to this! I’ll have a look at it when I return from holiday next week. |
This is the official PR for review.