Chore: add e2e tests for "no choices" behavior to match v10

Choices-js · Aug 30, 2024 · 7b7c1c7 · 7b7c1c7
1 parent e73f7e5
commit 7b7c1c7
Show file tree

Hide file tree

Showing 5 changed files with 55 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,12 @@
 # Changelog
 
+## [11.0.2]
+
+### Bug Fixes (from 11.0.0)
+
+### Chore
+* Add e2e tests for "no choices" behavior to match v10
+
 ## [11.0.1] (2024-08-30)
 
 ### Bug Fixes (from 11.0.0)

diff --git a/public/test/select-multiple/index.html b/public/test/select-multiple/index.html
@@ -161,6 +161,19 @@ <h2>Select multiple inputs</h2>
           </script>
         </div>
 
+        <div data-test-hook="no-choices">
+          <label for="no-choices">No choices</label>
+          <select class="form-control" name="no-choices" id="no-choices">
+          </select>
+          <script>
+            document.addEventListener('DOMContentLoaded', function() {
+              new Choices('#no-choices', {
+                allowHTML: true,
+              });
+            });
+          </script>
+        </div>
+
         <div data-test-hook="disabled-choice">
           <label for="choices-disabled-choice">Disabled choice</label>
           <select

diff --git a/public/test/select-one/index.html b/public/test/select-one/index.html
@@ -132,6 +132,19 @@ <h2>Select one inputs</h2>
           </script>
         </div>
 
+        <div data-test-hook="no-choices">
+          <label for="no-choices">No choices</label>
+          <select class="form-control" name="no-choices" id="no-choices">
+          </select>
+          <script>
+            document.addEventListener('DOMContentLoaded', function() {
+              new Choices('#no-choices', {
+                allowHTML: true,
+              });
+            });
+          </script>
+        </div>
+
         <div data-test-hook="disabled-choice">
           <label for="choices-disabled-choice">Disabled choice</label>
           <select

diff --git a/test-e2e/tests/select-multiple.spec.ts b/test-e2e/tests/select-multiple.spec.ts
@@ -375,6 +375,17 @@ describe(`Choices - select multiple`, () => {
       });
     });
 
+    describe('no choices', () => {
+      const testId = 'no-choices';
+      test('shows no choices banner', async ({ page, bundle }) => {
+        const suite = new SelectTestSuit(page, bundle, testUrl, testId);
+        await suite.startWithClick();
+
+        await expect(suite.selectableChoices).toHaveCount(0);
+        await suite.expectVisibleNoticeHtml('No choices to choose from');
+      });
+    });
+
     describe('disabled choice', () => {
       const testId = 'disabled-choice';
       const firstChoice = 'Choice 1';

diff --git a/test-e2e/tests/select-one.spec.ts b/test-e2e/tests/select-one.spec.ts
@@ -232,6 +232,17 @@ describe(`Choices - select one`, () => {
       });
     });
 
+    describe('no choices', () => {
+      const testId = 'no-choices';
+      test('shows no choices banner', async ({ page, bundle }) => {
+        const suite = new SelectTestSuit(page, bundle, testUrl, testId);
+        await suite.startWithClick();
+
+        await expect(suite.selectableChoices).toHaveCount(0);
+        await suite.expectVisibleNoticeHtml('No choices to choose from');
+      });
+    });
+
     describe('disabled choice', () => {
       const testId = 'disabled-choice';
       const firstChoice = 'Choice 1';