Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump CI python version #396

Closed
wants to merge 2 commits into from
Closed

Bump CI python version #396

wants to merge 2 commits into from

Conversation

ChiaMineJP
Copy link
Contributor

Python 3.7 was out of date.
(Python 3.8 will be end of life October this year)

@ChiaMineJP ChiaMineJP added the dependencies Pull requests that update a dependency file label Apr 8, 2024
@ChiaMineJP ChiaMineJP self-assigned this Apr 8, 2024
@coveralls-official Coveralls Official
Copy link

coveralls-official bot commented Apr 8, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 8598872025

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.07%) to 94.427%
Totals Coverage Status
Change from base Build 8310295107: 0.07%
Covered Lines: 5761
Relevant Lines: 6101
💛 - Coveralls

@ChiaMineJP ChiaMineJP changed the title Bump python version to 3.8 on CI Bump CI python version Apr 8, 2024
altendky
altendky approved these changes Apr 9, 2024
View reviewed changes
Copy link
Contributor

@altendky altendky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC, the CI here needs fully reworked. But sure, for now we can use a more recent python version.

@ChiaMineJP
Copy link
Contributor Author

Closing since #400 has been merged.

@ChiaMineJP ChiaMineJP closed this May 1, 2024
@ChiaMineJP ChiaMineJP deleted the cmj.ci-python-3.8 branch May 1, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@altendky altendky altendky approved these changes

@richardkiss richardkiss Awaiting requested review from richardkiss

Assignees

@ChiaMineJP ChiaMineJP

Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ChiaMineJP @altendky