Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an implementation of
serialized_length_from_bytes()
where any back-references are validated. Rename the existing function to indicate that the input is trusted (i.e. not fully validated).In support of this, it also adds:
serialized_length_from_bytes()
also parses correctlyobjective
The objective is to ensure that the buffer is a valid serialization if it passes this function. That way, an invalid CLVM program fails early, at parse-time, rather than time-of-use. Currently, the
Program
class inchia_rs
(the counterpart toSerializedProgram
) is parsed in a relaxed manner, and so might fail later, inrun()
.This can also tie into trusted- and untrusted parsing of
Streamable
. So trusted programs don't need to be validated to the same extent.benchmarks: