Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify raw-loops into while-loops #338

Merged
merged 1 commit into from
Aug 23, 2023
Merged

simplify raw-loops into while-loops #338

merged 1 commit into from
Aug 23, 2023

Conversation

arvidn
Copy link
Contributor

@arvidn arvidn commented Aug 22, 2023

in some cases this saves one or two levels of indentation of the loop body.
It always saves a few lines of code. It makes it more idiomatic rust I believe.

@coveralls-official
Copy link

Pull Request Test Coverage Report for Build 5941074672

  • 80 of 83 (96.39%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 93.812%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/serde/object_cache.rs 13 14 92.86%
src/serde/de_tree.rs 60 62 96.77%
Totals Coverage Status
Change from base Build 5894915712: -0.02%
Covered Lines: 5200
Relevant Lines: 5543

💛 - Coveralls

Copy link
Contributor

@Rigidity Rigidity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@arvidn arvidn merged commit 8a40f9c into main Aug 23, 2023
23 checks passed
@arvidn arvidn deleted the minor-simplification branch August 23, 2023 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants