Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change from using quay.io image and using the rustup script to a docker imag… #319

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Change from using quay.io image and using the rustup script to a docker imag… #319

wants to merge 13 commits into from

Conversation

pmaslana
Copy link
Contributor

…e and source

@pmaslana pmaslana changed the title Change from using podman and using the rustup script to a docker imag… Change from using quay.io image and using the rustup script to a docker imag… Jun 19, 2023
@coveralls-official
Copy link

coveralls-official bot commented Jun 19, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 5524940816

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.886%
Totals Coverage Status
Change from base Build 5513827559: 0.0%
Covered Lines: 5221
Relevant Lines: 5561
💛 - Coveralls

wjblanke
wjblanke previously approved these changes Jul 5, 2023
View reviewed changes
Copy link
Contributor

@wjblanke wjblanke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aok

prozacchiwawa
prozacchiwawa reviewed Jul 5, 2023
View reviewed changes
Copy link
Contributor

@prozacchiwawa prozacchiwawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok, based on inspection and running a modified version locally.

@github-actions
Copy link

'This PR has been flagged as stale due to no activity for over 60
days. It will not be automatically closed, but it has been given
a stale-pr label and should be manually reviewed.'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arvidn arvidn arvidn left review comments

@prozacchiwawa prozacchiwawa prozacchiwawa left review comments

@wjblanke wjblanke wjblanke left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
stale-pr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pmaslana @prozacchiwawa @arvidn @wjblanke