Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use generator for output directory #218

Merged
merged 3 commits into from
Oct 31, 2024
Merged

Use generator for output directory #218

merged 3 commits into from
Oct 31, 2024

Conversation

emlowe
Copy link
Contributor

@emlowe emlowe commented Oct 30, 2024

Using a "fake" generator for the directory makes the directory work in a simplified cross platform way.

Multi-configuration generators ([Visual Studio], [Xcode], [Ninja Multi-Config]) append a per-configuration subdirectory to the specified directory unless a generator expression is used

Rigidity
Rigidity previously approved these changes Oct 31, 2024
Copy link
Contributor

@AmineKhaldi AmineKhaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, left two suggestions that are familiar to CMake users.

src/CMakeLists.txt Outdated Show resolved Hide resolved
src/CMakeLists.txt Outdated Show resolved Hide resolved
@emlowe emlowe marked this pull request as ready for review October 31, 2024 15:28
@emlowe emlowe merged commit f96f083 into main Oct 31, 2024
60 checks passed
@emlowe emlowe deleted the EL.output-generator branch October 31, 2024 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants