Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add python 3.12 #160

Merged
merged 16 commits into from
Jan 24, 2024
Merged

Add python 3.12 #160

merged 16 commits into from
Jan 24, 2024

Conversation

emlowe
Copy link
Contributor

@emlowe emlowe commented Jan 22, 2024

For increased simplicity, this PR removes the Cmake version check from setup.py. The minimum cmake version is set in the CMakeLists.txt
Also removes distutils from setup.py

Switches out the CNI-specific windows delocate for delvewheel which is the current method recommended by cibuildwheel for wheel repair on Windows. Appears to work but might need some additional testing on other CPU flavours to make sure the correct DLL is loaded.

  • Tested on a Haswell CPU and the proper DLL was loaded (mpir_haswell.dll)
  • Confirmed all the other DLLs are present in the wheel package, so I hope this is working correctly

@hoffmang9
Copy link
Member

Related - Chia-Network/build-images#64

@emlowe emlowe marked this pull request as ready for review January 23, 2024 00:45
Copy link
Member

@hoffmang9 hoffmang9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - we should enable 3.12 once we have a new docker image - it's still building...

@emlowe emlowe merged commit 3cd0004 into main Jan 24, 2024
45 checks passed
@emlowe emlowe deleted the EL-python3.12 branch January 24, 2024 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants