-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add bytes*.fill()
helper
#761
Draft
altendky
wants to merge
5
commits into
main
Choose a base branch
from
sized_bytes_fill_helper
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
import pytest | ||
|
||
from chia_rs.sized_bytes import bytes8 | ||
|
||
|
||
def test_fill_empty() -> None: | ||
assert bytes8.fill(b"", b"\x01") == bytes8([1, 1, 1, 1, 1, 1, 1, 1]) | ||
|
||
|
||
def test_fill_non_empty_with_single() -> None: | ||
assert bytes8.fill(b"\x02", b"\x01") == bytes8([1, 1, 1, 1, 1, 1, 1, 2]) | ||
|
||
|
||
def test_fill_non_empty_with_double() -> None: | ||
assert bytes8.fill(b"\x02\x02", b"\x01\x01") == bytes8([1, 1, 1, 1, 1, 1, 2, 2]) | ||
|
||
|
||
def test_fill_needed_with_0_length_fill_raises() -> None: | ||
with pytest.raises(ValueError): | ||
bytes8.fill(b"\x00", fill=b"") | ||
|
||
|
||
def test_fill_not_needed_with_0_length_fill_works() -> None: | ||
blob = b"\x00" * 8 | ||
assert bytes8.fill(blob, fill=b"") == bytes8(blob) | ||
|
||
|
||
def test_fill_not_multiple_raises() -> None: | ||
with pytest.raises(ValueError): | ||
bytes8.fill(b"\x00", fill=b"\x01\x01") | ||
|
||
def test_align_left() -> None: | ||
assert bytes8.fill(b"\x01", fill=b"\x02", align="<") == bytes8([1, 2, 2, 2, 2, 2, 2, 2]) | ||
|
||
def test_invalid_alignment() -> None: | ||
with pytest.raises(ValueError): | ||
bytes8.fill(b"", fill=b"\x00", align="|") |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if
len(blob) > cls._size
, do we want to truncate and constructcls
then too?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am tending towards no. It seems like with these classes that truncation would be surprising. I think most use cases for this are tests where you are trying to create unique values. If your blob is too long and is truncated you hazard unexpectedly having multiple of the same value generated.
This isn't meant to be a 'format' level tool, but I will note that format just creates a larger output in this case.