Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CHIA-1527: Add chia-sha2 crate to prevent cyclic dependency with clvmr #735

Merged
merged 2 commits into from
Sep 27, 2024
Merged

CHIA-1527: Add chia-sha2 crate to prevent cyclic dependency with clvmr #735

merged 2 commits into from
Sep 27, 2024

Conversation

Rigidity
Copy link
Contributor

No description provided.

@Rigidity Rigidity changed the title Add chia-sha2 crate to prevent cyclic dependency with clvmr CHIA-1527: Add chia-sha2 crate to prevent cyclic dependency with clvmr Sep 27, 2024
arvidn
arvidn approved these changes Sep 27, 2024
View reviewed changes
Copy link
Contributor

@arvidn arvidn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I take it most of this was copied verbatim from clvm_rs, right?

@Rigidity
Copy link
Contributor Author

I take it most of this was copied verbatim from clvm_rs, right?

Yeah the sha2.rs file just copied over

@Rigidity Rigidity merged commit b9db810 into main Sep 27, 2024
59 checks passed
@Rigidity Rigidity deleted the chia-sha2 branch September 27, 2024 15:35
@coveralls-official Coveralls Official
Copy link

Pull Request Test Coverage Report for Build 11073022757

Details

  • 47 of 47 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 83.478%
Totals Coverage Status
Change from base Build 11040364341: 0.05%
Covered Lines: 12520
Relevant Lines: 14998
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arvidn arvidn arvidn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rigidity @arvidn