Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove bench and build from pre-commit #694

Merged
merged 1 commit into from
Aug 30, 2024
Merged

Remove bench and build from pre-commit #694

merged 1 commit into from
Aug 30, 2024

Conversation

Rigidity
Copy link
Contributor

@Rigidity Rigidity commented Aug 29, 2024 •
edited
Loading

Building and benchmarking the whole workspace takes a while and I'm not sure it's that necessary given that we have CI.

@Rigidity Rigidity requested a review from arvidn August 29, 2024 16:39
@coveralls-official Coveralls Official
Copy link

Pull Request Test Coverage Report for Build 10619122668

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 83.895%
Totals Coverage Status
Change from base Build 10618872395: 0.0%
Covered Lines: 12304
Relevant Lines: 14666
💛 - Coveralls

@Rigidity Rigidity merged commit f0b3839 into main Aug 30, 2024
59 checks passed
@Rigidity Rigidity deleted the precommit-speedup branch August 30, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arvidn arvidn arvidn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rigidity @arvidn