Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 3 unused parameters from ConsensusConstants #691

Merged
merged 6 commits into from
Aug 29, 2024

Conversation

matt-o-how
Copy link
Contributor

soft_fork2_height, soft_fork4_height, and hard_fork_fix_height are now no longer in use and can be safely removed

@matt-o-how matt-o-how requested a review from arvidn August 28, 2024 14:49
Copy link

Pull Request Test Coverage Report for Build 10598784102

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 83.891%

Totals Coverage Status
Change from base Build 10585347523: 0.0%
Covered Lines: 12301
Relevant Lines: 14663

💛 - Coveralls

@arvidn
Copy link
Contributor

arvidn commented Aug 29, 2024

this looks good. it makes me a bit nervous to leave the line ending commits in here though. If this PR lands with a merge commit, it will ruin our history for those files.

@arvidn
Copy link
Contributor

arvidn commented Aug 29, 2024

I'll just squash and merge

@arvidn arvidn merged commit 0c97565 into main Aug 29, 2024
61 checks passed
@arvidn arvidn deleted the remove_unused_consensusconstants branch August 29, 2024 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants