Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve CI workflows #677

Closed
wants to merge 30 commits into from
Closed

Improve CI workflows #677

wants to merge 30 commits into from

Conversation

Rigidity
Copy link
Contributor

@Rigidity Rigidity commented Aug 26, 2024

Makes the following changes:

  • Splits build-crate-and-npm into two separate workflows
  • Improves Rust tests by covering the whole workspace in both release and debug mode, with all features
  • Removes redundant build check for chia-tools, since it's part of the workspace
  • Adds cargo-machete to check unused dependencies (which have also been removed)
  • Uses cargo-lcov and pytest-cov for coverage instead of grcov, and uploads two separate reports
  • Other small changes to the workflows

Copy link

coveralls-official bot commented Aug 26, 2024

Pull Request Test Coverage Report for Build 10584734575

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 390 unchanged lines in 9 files lost coverage.
  • Overall coverage decreased (-0.5%) to 83.419%

Files with Coverage Reduction New Missed Lines %
crates/chia-consensus/src/gen/owned_conditions.rs 1 96.0%
crates/chia-consensus/src/gen/validation_error.rs 1 25.81%
wheel/src/run_program.rs 2 94.29%
crates/chia-consensus/src/gen/run_block_generator.rs 3 95.56%
crates/chia-consensus/src/gen/conditions.rs 5 99.26%
crates/chia-consensus/src/merkle_tree.rs 30 91.22%
wheel/src/run_generator.rs 59 5.33%
crates/chia-protocol/src/program.rs 140 31.74%
wheel/src/api.rs 149 52.16%
Totals Coverage Status
Change from base Build 10582586898: -0.5%
Covered Lines: 12059
Relevant Lines: 14456

💛 - Coveralls

@Rigidity Rigidity marked this pull request as ready for review August 27, 2024 16:56
@Rigidity Rigidity changed the title Yet another refactor attempt of the CI Improve CI workflows Aug 27, 2024
@Rigidity Rigidity closed this Aug 27, 2024
@Rigidity Rigidity reopened this Aug 27, 2024
@arvidn
Copy link
Contributor

arvidn commented Aug 28, 2024

these seems like really useful changes. They would be much easier to review if split up into separate PRs

@Rigidity Rigidity marked this pull request as draft August 28, 2024 13:57
@Rigidity Rigidity closed this Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants