-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CHIA-886: Redesign ToClvm and FromClvm to be generic over Encoder and Decoder #592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rigidity
changed the title
ToClvm/FromClvm use Encoder/Decoder traits, rather than Node
CHIA-886: Redesign ToClvm and FromClvm to be generic over Encoder and Decoder
Jul 2, 2024
Pull Request Test Coverage Report for Build 9755162032Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9767103062Details
💛 - Coveralls |
arvidn
reviewed
Jul 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really like this direction. There were some details that looked fishy
arvidn
reviewed
Jul 26, 2024
arvidn
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes a few changes:
ToClvm
is generic overEncoder
rather thanNode
.FromClvm
is generic overDecoder
rather thanNode
.ToNodePtr
andFromNodePtr
have been removed since they are no longer needed.Program
can now implementToClvm<Allocator>
andFromClvm<Allocator>
directly.Encoder
now has a method forencode_bigint
andencode_atom
takes aclvmr::Atom
instead of&[u8]
.