Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add python source to Cargo.toml #585

Merged
merged 3 commits into from
Jul 8, 2024
Merged

Add python source to Cargo.toml #585

merged 3 commits into from
Jul 8, 2024

Conversation

Quexington
Copy link
Contributor

I made this because it allows me to specify a specific commit to install chia_rs from with pip. Without this entry, the stub file doesn't come along and mypy doesn't function properly. The chia-blockchain CI has some difficulties with this but I think that's because it is manually building it when installing from the commit rather than installing from a published version. I'm not entirely sure how to check that though so some input on how reasonable this seems would be appreciated.

@Rigidity
Copy link
Contributor

Source installations via pip working is blocked on this issue:
#349

@Quexington
Copy link
Contributor Author

Source installations via pip working is blocked on this issue: #349

I don't follow this thread so well this is not my domain of expertise but I don't think this requires anything new to happen during your run of the mill build process, it just enables pip installing from source to work (on at least some platforms). I don't know though.

Copy link

coveralls-official bot commented Jun 25, 2024

Pull Request Test Coverage Report for Build 9669819579

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 287 unchanged lines in 10 files lost coverage.
  • Overall coverage increased (+2.0%) to 80.756%

Files with Coverage Reduction New Missed Lines %
crates/chia-protocol/src/classgroup.rs 1 0.0%
crates/chia-bls/src/error.rs 4 0.0%
crates/chia-traits/src/streamable.rs 9 92.54%
crates/chia-bls/src/secret_key.rs 11 89.95%
crates/chia-bls/src/signature.rs 19 93.94%
crates/chia-bls/src/public_key.rs 19 90.45%
wheel/src/api.rs 43 66.67%
crates/chia-bls/src/gtelement.rs 47 9.47%
crates/chia-bls/src/bls_cache.rs 51 73.16%
crates/chia-protocol/src/block_record.rs 83 0.0%
Totals Coverage Status
Change from base Build 9645397669: 2.0%
Covered Lines: 11393
Relevant Lines: 14108

💛 - Coveralls

Copy link
Contributor

@Rigidity Rigidity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see anything wrong with this, but it's marked as draft - so that's why I haven't approved sooner.

@Quexington Quexington changed the title [DRAFT] Add python source to Cargo.toml Add python source to Cargo.toml Jul 8, 2024
@Quexington
Copy link
Contributor Author

As long as no one sees any unexpected side effects of this then go ahead and merge it at your convenience

@Quexington Quexington merged commit 9cc904b into main Jul 8, 2024
64 checks passed
@Quexington Quexington deleted the quex.pip_install branch July 8, 2024 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants