fix trusted wallet sync on deep reorg #18831
Draft
+101
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
almogdepaz
added
Wallet
full_node
sync
Fixed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this makes the wallet able to handle deep reorgs on trusted sync without losing state
Purpose:
fix wallet trusted sync on deep reorgs
Current Behavior:
wallet doesn't get the correct forkpoint from the full node and does not rolleback to the correct block, currently when we finish long sync in the fullnode we send peak_height -1 as the forkpoint to the wallet
New Behavior:
send the correct forkpoint from the node after we finish the long sync and make wallet rolleback to the forkpoint before using the wallet long_sync to sync to the new peak
Testing Notes: