Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHIA-1236] Sort offers in CLI by RELEVANCE #18824

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Quexington
Copy link
Contributor

Previously these were sorted in reverse order of confirmed time. This should be a better sort that is closer to how the GUI displays offers. It should also make expired offers easier to find and cancel.

@Quexington Quexington added the Changed Required label for PR that categorizes merge commit message as "Changed" for changelog label Nov 5, 2024
@Quexington Quexington marked this pull request as ready for review November 5, 2024 20:13
@Quexington Quexington requested a review from a team as a code owner November 5, 2024 20:13
Copy link

Pull Request Test Coverage Report for Build 11691780964

Details

  • 3 of 3 (100.0%) changed or added relevant lines in 2 files are covered.
  • 19 unchanged lines in 7 files lost coverage.
  • Overall coverage increased (+0.02%) to 90.92%

Files with Coverage Reduction New Missed Lines %
chia/_tests/simulation/test_simulation.py 1 96.45%
chia/server/node_discovery.py 1 81.28%
chia/daemon/client.py 1 74.1%
chia/server/server.py 1 81.84%
chia/data_layer/data_layer.py 2 86.09%
chia/full_node/full_node.py 6 85.71%
chia/daemon/server.py 7 83.28%
Totals Coverage Status
Change from base Build 11691476343: 0.02%
Covered Lines: 102811
Relevant Lines: 112847

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changed Required label for PR that categorizes merge commit message as "Changed" for changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant