Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make timeloard launcher fail with a non-zero exit code on windows #18814

Merged
merged 2 commits into from
Nov 4, 2024
Merged

make timeloard launcher fail with a non-zero exit code on windows #18814

merged 2 commits into from
Nov 4, 2024

Conversation

altendky
Copy link
Contributor

@altendky altendky commented Nov 4, 2024

Purpose:

Current Behavior:

New Behavior:

Testing Notes:

@altendky altendky requested a review from a team as a code owner November 4, 2024 16:25
@altendky altendky added the Changed Required label for PR that categorizes merge commit message as "Changed" for changelog label Nov 4, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 4, 2024

File Coverage Missing Lines
chia/timelord/timelord_launcher.py 0.0% lines 178, 189
Total Missing Coverage
2 lines 2 lines 0%

@altendky altendky requested a review from emlowe November 4, 2024 17:59
@pmaslana pmaslana merged commit 2b19c28 into main Nov 4, 2024
361 of 363 checks passed
@pmaslana pmaslana deleted the altendky-patch-40 branch November 4, 2024 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emlowe emlowe emlowe approved these changes

Assignees
No one assigned
Labels
Changed Required label for PR that categorizes merge commit message as "Changed" for changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@altendky @emlowe @pmaslana