explicitly collect api methods instead of later using getattr #18800
+440
−328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
altendky
added
Changed
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
added
the
merge_conflict
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
github-actions
bot
removed
the
merge_conflict
Quexington
previously approved these changes
Nov 1, 2024
github-actions
bot
added
the
merge_conflict
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
AmineKhaldi
reviewed
Nov 1, 2024
AmineKhaldi
reviewed
Nov 1, 2024
Co-authored-by: Amine Khaldi <[email protected]>
github-actions
bot
removed
the
merge_conflict
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
Pull Request Test Coverage Report for Build 11713006287Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
AmineKhaldi
reviewed
Nov 6, 2024
|
|
||
| @metadata.request(request_type=ProtocolMessageTypes.handshake) | ||
| async def f(self: object, request: RequestTransaction) -> None: | ||
| pass |
There was a problem hiding this comment.
Suggested change
| pass | |
| pass # pragma: no cover |
| pass | ||
|
|
||
| async def g(self: object, request: RequestTransaction) -> None: | ||
| pass |
There was a problem hiding this comment.
Suggested change
| pass | |
| pass # pragma: no cover |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose:
i never really felt good about the
getattr()down inws_connection.py. beyond just addressing that, this gives each api implementation (FullNodeApietc) a specific object holding the api definition. a small step towards having a well formed definition of our api rather than having to iterate misc maybe-not-part-of-the-api methods anywhere you need to discover this information.Current Behavior:
New Behavior:
Testing Notes: