Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add use of rust datalayer merkle blob #18716

Draft
wants to merge 23 commits into
base: long_lived/datalayer_merkle_blob
Choose a base branch
from
Draft

add use of rust datalayer merkle blob #18716

wants to merge 23 commits into from

Conversation

altendky
Copy link
Contributor

Purpose:

Current Behavior:

New Behavior:

Testing Notes:

@altendky altendky added Added Required label for PR that categorizes merge commit message as "Added" for changelog Tests Changes to tests labels Oct 16, 2024
@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the merge_conflict Branch has conflicts that prevent merge to main label Oct 18, 2024
@github-actions github-actions bot removed the merge_conflict Branch has conflicts that prevent merge to main label Oct 22, 2024
@github-actions GitHub Actions
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions github-actions bot added the merge_conflict Branch has conflicts that prevent merge to main label Oct 23, 2024
@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the merge_conflict Branch has conflicts that prevent merge to main label Oct 23, 2024
@github-actions GitHub Actions
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

dependabot bot and others added 8 commits October 23, 2024 15:00
@dependabot
build(deps): bump coverage from 7.6.1 to 7.6.4 (#18748)
eb68369 
Bumps [coverage](https://github.com/nedbat/coveragepy) from 7.6.1 to 7.6.4.
- [Release notes](https://github.com/nedbat/coveragepy/releases)
- [Changelog](https://github.com/nedbat/coveragepy/blob/master/CHANGES.rst)
- [Commits](nedbat/coveragepy@7.6.1...7.6.4)

---
updated-dependencies:
- dependency-name: coverage
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@altendky
update chia_rs
6b7da84
@altendky
more lowercase types such as in comments (#18737)
2588600
@AmineKhaldi
CHIA-1664 Deduplicate cancel_task_safe (#18745)
f4ff9d6 
Deduplicate cancel_task_safe.
@altendky
add vpa virtual project package (#18754)
030ffdd
@AmineKhaldi
CHIA-1669 Simplify tx_additions and tx_removals in validate_block_mer…
36d7c01 
…kle_roots (#18758)

Simplify tx_additions and tx_removals in validate_block_merkle_roots.
@emlowe
Update clvm_tools_rs to 0.1.45 (#18761)
15d0daf
@altendky
update chia_rs
1d97291
@github-actions GitHub Actions
Copy link
Contributor

File Coverage Missing Lines
chia/_tests/core/data_layer/test_merkle_blob.py 58.1% lines 488, 490, 492-494, 496-497, 499-504
Total Missing Coverage
31 lines 13 lines 58%

arvidn and others added 4 commits October 25, 2024 08:38
@arvidn
[CHIA-1566] pipeline block validation in sync_from_fork_point() (#18703)
2df931b 
* make pre_validate_multi_processing() return futures, rather than the awaited and joined results from the thread jobs. This is crucial to allow the validaion jobs to run concurrently with the database interaction in the main thread

* Split up the add_block_batch() function into 3 parts, preparing them to be pipelined in long-sync

* pass AugmentedBlockchain into pre_validate_multiprocessing() and prevalidate_blocks(), to support the augmented blockchain to outlive a single batch

* pipeline pre-validation in sync_from_forkpoint()

* optimize the common case of _reconsider_peak(), to avoid one database lookup

* address review comments

* rename filter_blocks() -> skip_blocks(). It's is only relevant at the start of the sync, add comment and assert
@altendky
remove unnecessary use of .__members__ on ConditionOpcode iterati…
e2c63db 
…on (#18767)
@wjblanke
Keep track of all long sync task references (#18769)
0354e6e 
* keep track of all long sync task references

* List

* flake8

* flake8

* shorten comments... ooof indents

* comment
@Quexington
[CHIA-1553] Replace pylint with ruff (#18759)
6084112 
* Replace pylint with ruff

* poetry

* remove pylint

* Address comments by @altendky

* Undo formatting

* actually undo formatting
AmineKhaldi and others added 5 commits October 28, 2024 10:31
@AmineKhaldi
CHIA-1668 Move validate_block_merkle_roots next to validate_block_body (
03a41ac 
#18757)

Move validate_block_merkle_roots next to validate_block_body.
@AmineKhaldi
CHIA-1674 Remove no longer needed get_symmetric_key (#18770)
cfab9eb 
Remove no longer needed get_symmetric_key.
@emlowe
Try updating to psutil 6.1.0 (#18763)
c252a64 
* Try updating to psutil 6.1.0

* merge to origin\main

* Fixes
@altendky
correct wallet rpc api for get spendable coins with specified exclude…
6dee78a 
…d coins (#18768)

correct wallet rpc api for get spendable coins with specified excludied coins
@altendky
Merge branch 'main' into add_rs_merkle_blob
e19839e
@socket-security Socket Security
Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
pypi/[email protected] environment, eval, filesystem, network, shell, unsafe 0 36.2 MB astral-bot, crmarsh, zanie

🚮 Removed packages: pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected]

View full report↗︎

@socket-security Socket Security
Copy link

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSourceCI
Native code pypi/[email protected] 🚫
Native code pypi/[email protected] 🚫

View full report↗︎

Next steps

Why is native code a concern?

Contains native code (e.g., compiled binaries or shared libraries). Including native code can obscure malicious behavior.

Verify that the inclusion of native code is expected and necessary for this package's functionality. If it is unnecessary or unexpected, consider using alternative packages without native code to mitigate potential risks.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

@altendky altendky mentioned this pull request Oct 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Added Required label for PR that categorizes merge commit message as "Added" for changelog coverage-diff Tests Changes to tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@altendky @AmineKhaldi @emlowe @arvidn @wjblanke @Quexington