Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Walletconnect endpoints for DIDs, Datalayer, and NFT Bulk Mint #2521

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Adding Walletconnect endpoints for DIDs, Datalayer, and NFT Bulk Mint #2521

wants to merge 11 commits into from

Conversation

ChiaMineJP
Copy link
Contributor

@ChiaMineJP ChiaMineJP commented Oct 25, 2024 •
edited
Loading

This is a complemental PR to complete the pending work by #2308

Changes from 2308 in summary:

  • Applying change requests in 2308
  • Fixing incompatible argument names of RPC APIs
  • Added missing response types for RPC APIs
  • Improved request permissions dialog

@ChiaMineJP ChiaMineJP self-assigned this Oct 25, 2024
@ChiaMineJP ChiaMineJP added the Added Required label for PR that categorizes merge commit message as "Added" for changelog label Oct 25, 2024
@ChiaMineJP ChiaMineJP mentioned this pull request Oct 25, 2024
Open
@ChiaMineJP ChiaMineJP closed this Oct 28, 2024
@ChiaMineJP ChiaMineJP reopened this Oct 28, 2024
@ChiaMineJP ChiaMineJP marked this pull request as ready for review November 2, 2024 03:32
@ChiaMineJP ChiaMineJP requested a review from a team as a code owner November 2, 2024 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seeden seeden Awaiting requested review from seeden

@BrandtH22 BrandtH22 Awaiting requested review from BrandtH22

@markelrod markelrod Awaiting requested review from markelrod

At least 1 approving review is required to merge this pull request.

Assignees

@ChiaMineJP ChiaMineJP

Labels
Added Required label for PR that categorizes merge commit message as "Added" for changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ChiaMineJP @Gaerax