-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated dependencies for walletconnect to work in dev mode #2271
base: main
Are you sure you want to change the base?
Conversation
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎ To accept the risk, merge this PR and you will not be notified again.
Next stepsWhat are AI warnings?AI has found some unusual behaviors which could indicate a security risk An AI system found a low-risk anomaly in this package. It may still be fine to use, but you should check that it is safe before proceeding. Take a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with
|
Checking Electron Release Note (from 27.0.0 to 29.0.1) ... Found changes which might affect Electron now released I'll test new Electron behavior on several platforms like
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested new Electron whether it can be launched without problems on the following OSes.
- m1 MacOS (14 Sonoma)
- Windows 10
- Ubuntu 22.04
- Fedora 39 (
npm run electron
works to launch GUI butnpx lerna run dev:skipLocales --scope=@chia-network/gui
didn't work. But this is not a regression since the base branch (main
) has the same issue)
So upgrading Electron is fine by me.
And one change request.
Please add the new package-lock.json
along with this package.json
. Without it, everytime we run npm install
, npm
generates new uncommited package-lock.json
'This PR has been flagged as stale due to no activity for over 60 |
No description provided.