Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated dependencies for walletconnect to work in dev mode #2271

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

trepca
Copy link
Contributor

@trepca trepca commented Feb 11, 2024

No description provided.

Copy link

Copy link

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSource
AI warning npm/[email protected]
  • Notes: The code appears to have risky practices such as downloading and executing binaries without validation and potential code execution via execSync. It does not contain obvious malware, but there is a risk associated with executing downloaded binaries and scripts without proper validation or integrity checks.
  • Confidence: 1.00
  • Severity: 0.60

View full report↗︎

Next steps

What are AI warnings?

AI has found some unusual behaviors which could indicate a security risk

An AI system found a low-risk anomaly in this package. It may still be fine to use, but you should check that it is safe before proceeding.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

@emlowe emlowe changed the title updated dependencies for walletconnect to work in devmove updated dependencies for walletconnect to work in dev mode Feb 23, 2024
@ChiaMineJP
Copy link
Contributor

ChiaMineJP commented Feb 26, 2024

Checking Electron Release Note (from 27.0.0 to 29.0.1) ...
https://releases.electronjs.org/releases/stable

Found changes which might affect chia-blockchain-gui

  • Apply module search paths restriction on worker and child process. #41137 (Also in 27, 29)

Electron now released 29.0.1 so we also have an option to specify Electron version to "29.0.1" in the package.json

I'll test new Electron behavior on several platforms like

  • Windows 10
  • m1 MacOS (14 Sonoma)
  • Ubuntu 22.04
  • Fedora 39

@seeden seeden self-requested a review February 26, 2024 14:21
Copy link
Contributor

@ChiaMineJP ChiaMineJP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested new Electron whether it can be launched without problems on the following OSes.

  • m1 MacOS (14 Sonoma)
  • Windows 10
  • Ubuntu 22.04
  • Fedora 39 (npm run electron works to launch GUI but npx lerna run dev:skipLocales --scope=@chia-network/gui didn't work. But this is not a regression since the base branch (main) has the same issue)

So upgrading Electron is fine by me.
And one change request.
Please add the new package-lock.json along with this package.json. Without it, everytime we run npm install, npm generates new uncommited package-lock.json

Copy link
Contributor

github-actions bot commented Jun 3, 2024

'This PR has been flagged as stale due to no activity for over 60
days. It will not be automatically closed, but it has been given
a stale-pr label and should be manually reviewed.'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants