Fix refetching plots after new plot is finished plotting #1761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zsolt-dev can we move it to useGetThrottlePlotQueueQuery? |
|
@seeden Indeed, its a better place for it. I provided and updated version. Thank you |
|
Please do not merge as still trying for a better solution... |
|
'This PR has been flagged as stale due to no activity for over 60 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #1728
What other solutions were considered:
Have the logic of clearing cache directly in the api-react
-> spend hours on it, could not make it work. Queries should not clear caches, mutations should...
Have the logic of clearing cache in useGetThrottlePlotQueueQuery
-> might be a better place, but this is obvious for the developer that some cache cleaning is happening. I can move it to useGetThrottlePlotQueueQuery if someone thinks its a better place.
Thank you