Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emulation of RISC-V H extension #197

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Emulation of RISC-V H extension #197

merged 1 commit into from
Sep 24, 2024

Conversation

francois141
Copy link
Collaborator

No description provided.

@francois141 francois141 linked an issue Sep 18, 2024 that may be closed by this pull request
H-mode support #195
Closed
@francois141 francois141 marked this pull request as draft September 18, 2024 15:39
@francois141 francois141 force-pushed the 195-h-mode-support branch 3 times, most recently from 998b935 to c5bc9bc Compare September 20, 2024 09:20
@francois141 francois141 added the enhancement New feature or request label Sep 20, 2024
@francois141 francois141 force-pushed the 195-h-mode-support branch 4 times, most recently from d68d596 to e06a794 Compare September 20, 2024 21:00
@francois141 francois141 marked this pull request as ready for review September 20, 2024 21:02
@francois141 francois141 added the Test Testing or CI setup label Sep 20, 2024
@francois141 francois141 removed the Test Testing or CI setup label Sep 20, 2024
@francois141 francois141 marked this pull request as draft September 20, 2024 21:29
@francois141 francois141 force-pushed the 195-h-mode-support branch 4 times, most recently from 03b7d59 to 4fa7109 Compare September 22, 2024 14:29
@francois141
Copy link
Collaborator Author

francois141 commented Sep 22, 2024 •
edited
Loading

After 5 hours of gdb.... green!!!! @CharlyCst You can review :-)

Please don't merge, I will read the documentation once again & see if I can catch a few bugs

@francois141 francois141 marked this pull request as ready for review September 22, 2024 14:36
@francois141 francois141 force-pushed the 195-h-mode-support branch 2 times, most recently from c3fd8a1 to 4fa7109 Compare September 22, 2024 14:41
@francois141 francois141 changed the title 195 h mode support Emulation of RISC-V H extension Sep 22, 2024
CharlyCst
CharlyCst reviewed Sep 23, 2024
View reviewed changes
Copy link
Owner

@CharlyCst CharlyCst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few things to fix here and there, in particular in the switch from payload to firmware (see comments), but otherwise looks good to me :)

firmware/hypervisor/main.rs Outdated Show resolved Hide resolved
firmware/hypervisor/main.rs Outdated Show resolved Hide resolved
src/arch/metal.rs Show resolved Hide resolved
src/decoder.rs Outdated Show resolved Hide resolved
src/virt.rs Outdated Show resolved Hide resolved
src/virt.rs Outdated Show resolved Hide resolved
@francois141 francois141 self-assigned this Sep 23, 2024
@francois141 francois141 force-pushed the 195-h-mode-support branch 2 times, most recently from a19b11d to 116c61d Compare September 23, 2024 16:51
CharlyCst
CharlyCst previously approved these changes Sep 24, 2024
View reviewed changes
Copy link
Owner

@CharlyCst CharlyCst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome looks all good to me now :)

I'll rebase and merge the PR

@francois141 @CharlyCst
Hypervisor extension emulation
b259cda 
In the RISC-V architecture, the Hypervisor extension (often referred to as H-extension) introduces a new privilege mode (HS-mode) that provides a virtualized environment. This allows a hypervisor to manage virtual machines, trapping certain privileged instructions and handling them in a way that maintains isolation between the host and guest operating systems. This commit emulates the behavior of this ISA extension in Miralis.
@CharlyCst CharlyCst merged commit 124195d into main Sep 24, 2024
1 check passed
@CharlyCst CharlyCst deleted the 195-h-mode-support branch September 24, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CharlyCst CharlyCst CharlyCst left review comments

Assignees

@francois141 francois141

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

H-mode support
2 participants
@francois141 @CharlyCst