Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove invalid workflow step #6246

Merged
merged 1 commit into from
Jan 2, 2024
Merged

fix: remove invalid workflow step #6246

merged 1 commit into from
Jan 2, 2024

Conversation

matthewkeil
Copy link
Member

@matthewkeil matthewkeil commented Jan 2, 2024 •
edited
Loading

Motivation

There was a logical bug in the workflow update. The command was valid but the repo is not checked out yet in order to validate the branch/tag/commit.

Description

Is a chicken/egg situation. I wanted to validate the ref before checkout but need repo to validate against. Remove invalid step. Checked in action/checkout source code that the ref is validated so an error still gets thrown for invalid input data and the workflow still aborts

@matthewkeil matthewkeil requested a review from a team as a code owner January 2, 2024 17:40
@matthewkeil matthewkeil enabled auto-merge (squash) January 2, 2024 17:43
@matthewkeil matthewkeil merged commit 9262064 into unstable Jan 2, 2024
17 of 18 checks passed
@matthewkeil matthewkeil deleted the mkeil/fix-docs-workflow branch January 2, 2024 18:03
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 2, 2024

Performance Report

✔️ no performance regression detected

Full benchmark results
Benchmark suite Current: f4ecfd6 Previous: b7925f6 Ratio
getPubkeys - index2pubkey - req 1000 vs - 250000 vc 618.28 us/op 622.17 us/op 0.99
getPubkeys - validatorsArr - req 1000 vs - 250000 vc 123.05 us/op 152.83 us/op 0.81
BLS verify - blst-native 1.3776 ms/op 1.3629 ms/op 1.01
BLS verifyMultipleSignatures 3 - blst-native 2.9334 ms/op 2.8205 ms/op 1.04
BLS verifyMultipleSignatures 8 - blst-native 6.5143 ms/op 6.1790 ms/op 1.05
BLS verifyMultipleSignatures 32 - blst-native 23.754 ms/op 24.291 ms/op 0.98
BLS verifyMultipleSignatures 64 - blst-native 46.563 ms/op 45.477 ms/op 1.02
BLS verifyMultipleSignatures 128 - blst-native 93.585 ms/op 90.261 ms/op 1.04
BLS deserializing 10000 signatures 960.50 ms/op 979.81 ms/op 0.98
BLS deserializing 100000 signatures 9.3037 s/op 9.2013 s/op 1.01
BLS verifyMultipleSignatures - same message - 3 - blst-native 1.3840 ms/op 1.4203 ms/op 0.97
BLS verifyMultipleSignatures - same message - 8 - blst-native 1.6319 ms/op 1.5523 ms/op 1.05
BLS verifyMultipleSignatures - same message - 32 - blst-native 2.4068 ms/op 2.4368 ms/op 0.99
BLS verifyMultipleSignatures - same message - 64 - blst-native 3.5899 ms/op 3.5211 ms/op 1.02
BLS verifyMultipleSignatures - same message - 128 - blst-native 5.7297 ms/op 5.9127 ms/op 0.97
BLS aggregatePubkeys 32 - blst-native 26.408 us/op 26.792 us/op 0.99
BLS aggregatePubkeys 128 - blst-native 102.19 us/op 101.42 us/op 1.01
getAttestationsForBlock 60.019 ms/op 63.710 ms/op 0.94
getSlashingsAndExits - default max 169.83 us/op 169.40 us/op 1.00
getSlashingsAndExits - 2k 635.99 us/op 473.50 us/op 1.34
proposeBlockBody type=full, size=empty 7.0182 ms/op 6.2559 ms/op 1.12
isKnown best case - 1 super set check 479.00 ns/op 557.00 ns/op 0.86
isKnown normal case - 2 super set checks 493.00 ns/op 648.00 ns/op 0.76
isKnown worse case - 16 super set checks 519.00 ns/op 753.00 ns/op 0.69
CheckpointStateCache - add get delete 5.9540 us/op 6.9400 us/op 0.86
validate api signedAggregateAndProof - struct 2.9463 ms/op 2.8773 ms/op 1.02
validate gossip signedAggregateAndProof - struct 2.9161 ms/op 2.8137 ms/op 1.04
validate gossip attestation - vc 640000 1.4500 ms/op 1.4314 ms/op 1.01
batch validate gossip attestation - vc 640000 - chunk 32 190.04 us/op 174.64 us/op 1.09
batch validate gossip attestation - vc 640000 - chunk 64 173.32 us/op 157.52 us/op 1.10
batch validate gossip attestation - vc 640000 - chunk 128 170.47 us/op 142.89 us/op 1.19
batch validate gossip attestation - vc 640000 - chunk 256 152.41 us/op 134.09 us/op 1.14
pickEth1Vote - no votes 1.3768 ms/op 1.3480 ms/op 1.02
pickEth1Vote - max votes 12.105 ms/op 11.010 ms/op 1.10
pickEth1Vote - Eth1Data hashTreeRoot value x2048 20.667 ms/op 17.982 ms/op 1.15
pickEth1Vote - Eth1Data hashTreeRoot tree x2048 34.917 ms/op 25.739 ms/op 1.36
pickEth1Vote - Eth1Data fastSerialize value x2048 718.21 us/op 658.06 us/op 1.09
pickEth1Vote - Eth1Data fastSerialize tree x2048 6.4595 ms/op 4.7164 ms/op 1.37
bytes32 toHexString 806.00 ns/op 612.00 ns/op 1.32
bytes32 Buffer.toString(hex) 334.00 ns/op 320.00 ns/op 1.04
bytes32 Buffer.toString(hex) from Uint8Array 554.00 ns/op 568.00 ns/op 0.98
bytes32 Buffer.toString(hex) + 0x 316.00 ns/op 326.00 ns/op 0.97
Object access 1 prop 0.20900 ns/op 0.21100 ns/op 0.99
Map access 1 prop 0.15600 ns/op 0.14600 ns/op 1.07
Object get x1000 7.8980 ns/op 7.6140 ns/op 1.04
Map get x1000 0.86500 ns/op 0.83900 ns/op 1.03
Object set x1000 60.328 ns/op 56.897 ns/op 1.06
Map set x1000 46.293 ns/op 43.526 ns/op 1.06
Return object 10000 times 0.26440 ns/op 0.24600 ns/op 1.07
Throw Error 10000 times 4.1340 us/op 3.9202 us/op 1.05
fastMsgIdFn sha256 / 200 bytes 3.5230 us/op 3.4020 us/op 1.04
fastMsgIdFn h32 xxhash / 200 bytes 365.00 ns/op 322.00 ns/op 1.13
fastMsgIdFn h64 xxhash / 200 bytes 412.00 ns/op 361.00 ns/op 1.14
fastMsgIdFn sha256 / 1000 bytes 12.239 us/op 11.669 us/op 1.05
fastMsgIdFn h32 xxhash / 1000 bytes 507.00 ns/op 470.00 ns/op 1.08
fastMsgIdFn h64 xxhash / 1000 bytes 509.00 ns/op 435.00 ns/op 1.17
fastMsgIdFn sha256 / 10000 bytes 109.91 us/op 104.53 us/op 1.05
fastMsgIdFn h32 xxhash / 10000 bytes 2.2650 us/op 1.9930 us/op 1.14
fastMsgIdFn h64 xxhash / 10000 bytes 1.5350 us/op 1.3760 us/op 1.12
send data - 1000 256B messages 25.116 ms/op 20.313 ms/op 1.24
send data - 1000 512B messages 31.718 ms/op 27.736 ms/op 1.14
send data - 1000 1024B messages 47.767 ms/op 42.117 ms/op 1.13
send data - 1000 1200B messages 42.237 ms/op 42.331 ms/op 1.00
send data - 1000 2048B messages 49.534 ms/op 47.721 ms/op 1.04
send data - 1000 4096B messages 46.905 ms/op 47.798 ms/op 0.98
send data - 1000 16384B messages 128.48 ms/op 121.37 ms/op 1.06
send data - 1000 65536B messages 520.97 ms/op 499.68 ms/op 1.04
enrSubnets - fastDeserialize 64 bits 1.5730 us/op 1.9030 us/op 0.83
enrSubnets - ssz BitVector 64 bits 549.00 ns/op 596.00 ns/op 0.92
enrSubnets - fastDeserialize 4 bits 225.00 ns/op 241.00 ns/op 0.93
enrSubnets - ssz BitVector 4 bits 561.00 ns/op 573.00 ns/op 0.98
prioritizePeers score -10:0 att 32-0.1 sync 2-0 119.21 us/op 132.24 us/op 0.90
prioritizePeers score 0:0 att 32-0.25 sync 2-0.25 159.95 us/op 162.08 us/op 0.99
prioritizePeers score 0:0 att 32-0.5 sync 2-0.5 203.99 us/op 210.34 us/op 0.97
prioritizePeers score 0:0 att 64-0.75 sync 4-0.75 350.76 us/op 345.15 us/op 1.02
prioritizePeers score 0:0 att 64-1 sync 4-1 384.21 us/op 383.70 us/op 1.00
array of 16000 items push then shift 1.8985 us/op 1.7680 us/op 1.07
LinkedList of 16000 items push then shift 9.3140 ns/op 9.5470 ns/op 0.98
array of 16000 items push then pop 108.24 ns/op 119.18 ns/op 0.91
LinkedList of 16000 items push then pop 9.1350 ns/op 9.2910 ns/op 0.98
array of 24000 items push then shift 2.6433 us/op 2.7613 us/op 0.96
LinkedList of 24000 items push then shift 9.1890 ns/op 10.811 ns/op 0.85
array of 24000 items push then pop 149.31 ns/op 175.64 ns/op 0.85
LinkedList of 24000 items push then pop 8.9450 ns/op 10.589 ns/op 0.84
intersect bitArray bitLen 8 7.1750 ns/op 7.5280 ns/op 0.95
intersect array and set length 8 65.143 ns/op 106.70 ns/op 0.61
intersect bitArray bitLen 128 34.560 ns/op 36.828 ns/op 0.94
intersect array and set length 128 923.50 ns/op 1.1313 us/op 0.82
bitArray.getTrueBitIndexes() bitLen 128 1.5770 us/op 2.1120 us/op 0.75
bitArray.getTrueBitIndexes() bitLen 248 2.7820 us/op 3.3880 us/op 0.82
bitArray.getTrueBitIndexes() bitLen 512 5.4920 us/op 6.2690 us/op 0.88
Buffer.concat 32 items 1.0500 us/op 1.1220 us/op 0.94
Uint8Array.set 32 items 2.1820 us/op 1.9180 us/op 1.14
Set add up to 64 items then delete first 4.6147 us/op 4.7042 us/op 0.98
OrderedSet add up to 64 items then delete first 5.6030 us/op 6.2409 us/op 0.90
Set add up to 64 items then delete last 5.0992 us/op 5.4127 us/op 0.94
OrderedSet add up to 64 items then delete last 6.4775 us/op 6.9183 us/op 0.94
Set add up to 64 items then delete middle 4.9168 us/op 5.2328 us/op 0.94
OrderedSet add up to 64 items then delete middle 7.3778 us/op 7.9601 us/op 0.93
Set add up to 128 items then delete first 10.389 us/op 10.237 us/op 1.01
OrderedSet add up to 128 items then delete first 14.493 us/op 14.392 us/op 1.01
Set add up to 128 items then delete last 10.543 us/op 10.396 us/op 1.01
OrderedSet add up to 128 items then delete last 13.595 us/op 13.844 us/op 0.98
Set add up to 128 items then delete middle 10.051 us/op 10.640 us/op 0.94
OrderedSet add up to 128 items then delete middle 18.693 us/op 19.692 us/op 0.95
Set add up to 256 items then delete first 20.870 us/op 23.009 us/op 0.91
OrderedSet add up to 256 items then delete first 27.916 us/op 31.467 us/op 0.89
Set add up to 256 items then delete last 20.294 us/op 21.318 us/op 0.95
OrderedSet add up to 256 items then delete last 25.466 us/op 29.037 us/op 0.88
Set add up to 256 items then delete middle 20.132 us/op 21.243 us/op 0.95
OrderedSet add up to 256 items then delete middle 50.054 us/op 52.236 us/op 0.96
transfer serialized Status (84 B) 1.8180 us/op 1.8200 us/op 1.00
copy serialized Status (84 B) 1.5960 us/op 1.5840 us/op 1.01
transfer serialized SignedVoluntaryExit (112 B) 1.9550 us/op 1.8940 us/op 1.03
copy serialized SignedVoluntaryExit (112 B) 1.6290 us/op 1.6770 us/op 0.97
transfer serialized ProposerSlashing (416 B) 2.1350 us/op 2.2690 us/op 0.94
copy serialized ProposerSlashing (416 B) 2.0130 us/op 2.2870 us/op 0.88
transfer serialized Attestation (485 B) 2.2390 us/op 2.3110 us/op 0.97
copy serialized Attestation (485 B) 2.1460 us/op 2.2920 us/op 0.94
transfer serialized AttesterSlashing (33232 B) 3.0870 us/op 2.2700 us/op 1.36
copy serialized AttesterSlashing (33232 B) 7.0520 us/op 7.8460 us/op 0.90
transfer serialized Small SignedBeaconBlock (128000 B) 3.5090 us/op 3.5840 us/op 0.98
copy serialized Small SignedBeaconBlock (128000 B) 20.031 us/op 24.637 us/op 0.81
transfer serialized Avg SignedBeaconBlock (200000 B) 3.9360 us/op 3.4910 us/op 1.13
copy serialized Avg SignedBeaconBlock (200000 B) 26.519 us/op 32.387 us/op 0.82
transfer serialized BlobsSidecar (524380 B) 4.0370 us/op 4.2380 us/op 0.95
copy serialized BlobsSidecar (524380 B) 93.267 us/op 110.23 us/op 0.85
transfer serialized Big SignedBeaconBlock (1000000 B) 4.1510 us/op 5.2980 us/op 0.78
copy serialized Big SignedBeaconBlock (1000000 B) 304.68 us/op 212.34 us/op 1.43
pass gossip attestations to forkchoice per slot 4.1952 ms/op 4.9974 ms/op 0.84
forkChoice updateHead vc 100000 bc 64 eq 0 688.79 us/op 705.85 us/op 0.98
forkChoice updateHead vc 600000 bc 64 eq 0 4.6608 ms/op 6.7691 ms/op 0.69
forkChoice updateHead vc 1000000 bc 64 eq 0 7.2499 ms/op 7.8503 ms/op 0.92
forkChoice updateHead vc 600000 bc 320 eq 0 4.3622 ms/op 4.8333 ms/op 0.90
forkChoice updateHead vc 600000 bc 1200 eq 0 4.4670 ms/op 5.3551 ms/op 0.83
forkChoice updateHead vc 600000 bc 7200 eq 0 5.4387 ms/op 6.4223 ms/op 0.85
forkChoice updateHead vc 600000 bc 64 eq 1000 11.382 ms/op 12.890 ms/op 0.88
forkChoice updateHead vc 600000 bc 64 eq 10000 12.335 ms/op 15.551 ms/op 0.79
forkChoice updateHead vc 600000 bc 64 eq 300000 16.268 ms/op 38.980 ms/op 0.42
computeDeltas 500000 validators 300 proto nodes 6.8822 ms/op 7.3235 ms/op 0.94
computeDeltas 500000 validators 1200 proto nodes 6.7896 ms/op 7.1200 ms/op 0.95
computeDeltas 500000 validators 7200 proto nodes 6.7471 ms/op 6.9668 ms/op 0.97
computeDeltas 750000 validators 300 proto nodes 10.508 ms/op 10.764 ms/op 0.98
computeDeltas 750000 validators 1200 proto nodes 10.066 ms/op 10.462 ms/op 0.96
computeDeltas 750000 validators 7200 proto nodes 10.021 ms/op 9.9554 ms/op 1.01
computeDeltas 1400000 validators 300 proto nodes 20.092 ms/op 19.308 ms/op 1.04
computeDeltas 1400000 validators 1200 proto nodes 19.773 ms/op 19.097 ms/op 1.04
computeDeltas 1400000 validators 7200 proto nodes 19.460 ms/op 22.254 ms/op 0.87
computeDeltas 2100000 validators 300 proto nodes 29.339 ms/op 34.779 ms/op 0.84
computeDeltas 2100000 validators 1200 proto nodes 29.136 ms/op 30.012 ms/op 0.97
computeDeltas 2100000 validators 7200 proto nodes 29.491 ms/op 30.447 ms/op 0.97
computeProposerBoostScoreFromBalances 500000 validators 4.0103 ms/op 4.0311 ms/op 0.99
computeProposerBoostScoreFromBalances 750000 validators 3.9211 ms/op 3.9089 ms/op 1.00
computeProposerBoostScoreFromBalances 1400000 validators 3.9902 ms/op 3.7617 ms/op 1.06
computeProposerBoostScoreFromBalances 2100000 validators 3.9992 ms/op 3.7133 ms/op 1.08
altair processAttestation - 250000 vs - 7PWei normalcase 2.3244 ms/op 2.2823 ms/op 1.02
altair processAttestation - 250000 vs - 7PWei worstcase 3.9393 ms/op 3.1857 ms/op 1.24
altair processAttestation - setStatus - 1/6 committees join 161.56 us/op 142.29 us/op 1.14
altair processAttestation - setStatus - 1/3 committees join 313.13 us/op 278.08 us/op 1.13
altair processAttestation - setStatus - 1/2 committees join 422.47 us/op 370.72 us/op 1.14
altair processAttestation - setStatus - 2/3 committees join 587.82 us/op 481.62 us/op 1.22
altair processAttestation - setStatus - 4/5 committees join 778.03 us/op 644.34 us/op 1.21
altair processAttestation - setStatus - 100% committees join 926.82 us/op 764.81 us/op 1.21
altair processBlock - 250000 vs - 7PWei normalcase 12.273 ms/op 10.018 ms/op 1.23
altair processBlock - 250000 vs - 7PWei normalcase hashState 47.663 ms/op 38.840 ms/op 1.23
altair processBlock - 250000 vs - 7PWei worstcase 45.154 ms/op 36.428 ms/op 1.24
altair processBlock - 250000 vs - 7PWei worstcase hashState 99.442 ms/op 94.995 ms/op 1.05
phase0 processBlock - 250000 vs - 7PWei normalcase 3.0488 ms/op 2.3572 ms/op 1.29
phase0 processBlock - 250000 vs - 7PWei worstcase 34.393 ms/op 30.132 ms/op 1.14
altair processEth1Data - 250000 vs - 7PWei normalcase 639.48 us/op 491.81 us/op 1.30
getExpectedWithdrawals 250000 eb:1,eth1:1,we:0,wn:0,smpl:15 13.659 us/op 12.885 us/op 1.06
getExpectedWithdrawals 250000 eb:0.95,eth1:0.1,we:0.05,wn:0,smpl:219 65.832 us/op 55.150 us/op 1.19
getExpectedWithdrawals 250000 eb:0.95,eth1:0.3,we:0.05,wn:0,smpl:42 25.913 us/op 20.692 us/op 1.25
getExpectedWithdrawals 250000 eb:0.95,eth1:0.7,we:0.05,wn:0,smpl:18 13.266 us/op 8.4890 us/op 1.56
getExpectedWithdrawals 250000 eb:0.1,eth1:0.1,we:0,wn:0,smpl:1020 244.52 us/op 137.33 us/op 1.78
getExpectedWithdrawals 250000 eb:0.03,eth1:0.03,we:0,wn:0,smpl:11777 1.1605 ms/op 1.3438 ms/op 0.86
getExpectedWithdrawals 250000 eb:0.01,eth1:0.01,we:0,wn:0,smpl:16384 1.5126 ms/op 1.7834 ms/op 0.85
getExpectedWithdrawals 250000 eb:0,eth1:0,we:0,wn:0,smpl:16384 2.7748 ms/op 1.7493 ms/op 1.59
getExpectedWithdrawals 250000 eb:0,eth1:0,we:0,wn:0,nocache,smpl:16384 4.3014 ms/op 3.6547 ms/op 1.18
getExpectedWithdrawals 250000 eb:0,eth1:1,we:0,wn:0,smpl:16384 3.2333 ms/op 2.2302 ms/op 1.45
getExpectedWithdrawals 250000 eb:0,eth1:1,we:0,wn:0,nocache,smpl:16384 8.3576 ms/op 5.3505 ms/op 1.56
Tree 40 250000 create 793.13 ms/op 374.18 ms/op 2.12
Tree 40 250000 get(125000) 230.32 ns/op 204.80 ns/op 1.12
Tree 40 250000 set(125000) 3.0982 us/op 1.1662 us/op 2.66
Tree 40 250000 toArray() 29.965 ms/op 22.217 ms/op 1.35
Tree 40 250000 iterate all - toArray() + loop 30.122 ms/op 23.546 ms/op 1.28
Tree 40 250000 iterate all - get(i) 85.495 ms/op 74.445 ms/op 1.15
MutableVector 250000 create 21.082 ms/op 12.660 ms/op 1.67
MutableVector 250000 get(125000) 7.2520 ns/op 7.1080 ns/op 1.02
MutableVector 250000 set(125000) 688.28 ns/op 311.19 ns/op 2.21
MutableVector 250000 toArray() 7.7037 ms/op 4.0459 ms/op 1.90
MutableVector 250000 iterate all - toArray() + loop 5.2832 ms/op 3.6204 ms/op 1.46
MutableVector 250000 iterate all - get(i) 1.6719 ms/op 1.5358 ms/op 1.09
Array 250000 create 5.1899 ms/op 2.6525 ms/op 1.96
Array 250000 clone - spread 1.9019 ms/op 1.3197 ms/op 1.44
Array 250000 get(125000) 2.1610 ns/op 1.0700 ns/op 2.02
Array 250000 set(125000) 5.6710 ns/op 4.1720 ns/op 1.36
Array 250000 iterate all - loop 185.01 us/op 172.89 us/op 1.07
effectiveBalanceIncrements clone Uint8Array 300000 48.519 us/op 28.449 us/op 1.71
effectiveBalanceIncrements clone MutableVector 300000 371.00 ns/op 348.00 ns/op 1.07
effectiveBalanceIncrements rw all Uint8Array 300000 212.63 us/op 201.92 us/op 1.05
effectiveBalanceIncrements rw all MutableVector 300000 91.707 ms/op 85.286 ms/op 1.08
phase0 afterProcessEpoch - 250000 vs - 7PWei 122.90 ms/op 112.20 ms/op 1.10
phase0 beforeProcessEpoch - 250000 vs - 7PWei 60.434 ms/op 54.769 ms/op 1.10
altair processEpoch - mainnet_e81889 570.09 ms/op 493.41 ms/op 1.16
mainnet_e81889 - altair beforeProcessEpoch 63.560 ms/op 83.641 ms/op 0.76
mainnet_e81889 - altair processJustificationAndFinalization 18.171 us/op 15.440 us/op 1.18
mainnet_e81889 - altair processInactivityUpdates 7.1943 ms/op 6.5700 ms/op 1.10
mainnet_e81889 - altair processRewardsAndPenalties 77.938 ms/op 64.090 ms/op 1.22
mainnet_e81889 - altair processRegistryUpdates 4.4460 us/op 2.8720 us/op 1.55
mainnet_e81889 - altair processSlashings 604.00 ns/op 557.00 ns/op 1.08
mainnet_e81889 - altair processEth1DataReset 567.00 ns/op 695.00 ns/op 0.82
mainnet_e81889 - altair processEffectiveBalanceUpdates 1.8015 ms/op 1.6944 ms/op 1.06
mainnet_e81889 - altair processSlashingsReset 7.2860 us/op 3.6840 us/op 1.98
mainnet_e81889 - altair processRandaoMixesReset 5.4850 us/op 5.9480 us/op 0.92
mainnet_e81889 - altair processHistoricalRootsUpdate 1.0020 us/op 1.0610 us/op 0.94
mainnet_e81889 - altair processParticipationFlagUpdates 2.8160 us/op 2.9280 us/op 0.96
mainnet_e81889 - altair processSyncCommitteeUpdates 966.00 ns/op 841.00 ns/op 1.15
mainnet_e81889 - altair afterProcessEpoch 132.33 ms/op 120.72 ms/op 1.10
capella processEpoch - mainnet_e217614 2.3711 s/op 2.4058 s/op 0.99
mainnet_e217614 - capella beforeProcessEpoch 533.68 ms/op 532.62 ms/op 1.00
mainnet_e217614 - capella processJustificationAndFinalization 15.881 us/op 25.667 us/op 0.62
mainnet_e217614 - capella processInactivityUpdates 22.518 ms/op 29.729 ms/op 0.76
mainnet_e217614 - capella processRewardsAndPenalties 478.16 ms/op 440.18 ms/op 1.09
mainnet_e217614 - capella processRegistryUpdates 25.179 us/op 38.834 us/op 0.65
mainnet_e217614 - capella processSlashings 586.00 ns/op 1.2710 us/op 0.46
mainnet_e217614 - capella processEth1DataReset 458.00 ns/op 653.00 ns/op 0.70
mainnet_e217614 - capella processEffectiveBalanceUpdates 5.2836 ms/op 5.1221 ms/op 1.03
mainnet_e217614 - capella processSlashingsReset 6.6740 us/op 4.4430 us/op 1.50
mainnet_e217614 - capella processRandaoMixesReset 6.0720 us/op 5.0830 us/op 1.19
mainnet_e217614 - capella processHistoricalRootsUpdate 615.00 ns/op 609.00 ns/op 1.01
mainnet_e217614 - capella processParticipationFlagUpdates 3.5230 us/op 1.6490 us/op 2.14
mainnet_e217614 - capella afterProcessEpoch 325.40 ms/op 340.00 ms/op 0.96
phase0 processEpoch - mainnet_e58758 500.67 ms/op 580.14 ms/op 0.86
mainnet_e58758 - phase0 beforeProcessEpoch 133.59 ms/op 186.20 ms/op 0.72
mainnet_e58758 - phase0 processJustificationAndFinalization 16.149 us/op 30.418 us/op 0.53
mainnet_e58758 - phase0 processRewardsAndPenalties 60.875 ms/op 63.051 ms/op 0.97
mainnet_e58758 - phase0 processRegistryUpdates 9.7280 us/op 15.545 us/op 0.63
mainnet_e58758 - phase0 processSlashings 642.00 ns/op 663.00 ns/op 0.97
mainnet_e58758 - phase0 processEth1DataReset 685.00 ns/op 818.00 ns/op 0.84
mainnet_e58758 - phase0 processEffectiveBalanceUpdates 1.4478 ms/op 1.6036 ms/op 0.90
mainnet_e58758 - phase0 processSlashingsReset 4.6440 us/op 3.6420 us/op 1.28
mainnet_e58758 - phase0 processRandaoMixesReset 7.7300 us/op 6.7790 us/op 1.14
mainnet_e58758 - phase0 processHistoricalRootsUpdate 556.00 ns/op 1.0550 us/op 0.53
mainnet_e58758 - phase0 processParticipationRecordUpdates 4.8610 us/op 4.6310 us/op 1.05
mainnet_e58758 - phase0 afterProcessEpoch 109.13 ms/op 97.358 ms/op 1.12
phase0 processEffectiveBalanceUpdates - 250000 normalcase 1.4963 ms/op 1.4412 ms/op 1.04
phase0 processEffectiveBalanceUpdates - 250000 worstcase 0.5 2.5171 ms/op 1.7811 ms/op 1.41
altair processInactivityUpdates - 250000 normalcase 26.466 ms/op 34.256 ms/op 0.77
altair processInactivityUpdates - 250000 worstcase 33.091 ms/op 42.101 ms/op 0.79
phase0 processRegistryUpdates - 250000 normalcase 11.320 us/op 12.094 us/op 0.94
phase0 processRegistryUpdates - 250000 badcase_full_deposits 503.12 us/op 450.98 us/op 1.12
phase0 processRegistryUpdates - 250000 worstcase 0.5 170.83 ms/op 178.43 ms/op 0.96
altair processRewardsAndPenalties - 250000 normalcase 70.708 ms/op 56.129 ms/op 1.26
altair processRewardsAndPenalties - 250000 worstcase 73.128 ms/op 82.836 ms/op 0.88
phase0 getAttestationDeltas - 250000 normalcase 13.002 ms/op 16.795 ms/op 0.77
phase0 getAttestationDeltas - 250000 worstcase 13.632 ms/op 14.448 ms/op 0.94
phase0 processSlashings - 250000 worstcase 123.37 us/op 134.19 us/op 0.92
altair processSyncCommitteeUpdates - 250000 184.11 ms/op 189.45 ms/op 0.97
BeaconState.hashTreeRoot - No change 288.00 ns/op 345.00 ns/op 0.83
BeaconState.hashTreeRoot - 1 full validator 184.01 us/op 236.86 us/op 0.78
BeaconState.hashTreeRoot - 32 full validator 2.0011 ms/op 2.3848 ms/op 0.84
BeaconState.hashTreeRoot - 512 full validator 25.141 ms/op 25.771 ms/op 0.98
BeaconState.hashTreeRoot - 1 validator.effectiveBalance 235.18 us/op 221.28 us/op 1.06
BeaconState.hashTreeRoot - 32 validator.effectiveBalance 3.1925 ms/op 3.1985 ms/op 1.00
BeaconState.hashTreeRoot - 512 validator.effectiveBalance 42.812 ms/op 46.183 ms/op 0.93
BeaconState.hashTreeRoot - 1 balances 206.95 us/op 199.69 us/op 1.04
BeaconState.hashTreeRoot - 32 balances 1.6199 ms/op 2.1972 ms/op 0.74
BeaconState.hashTreeRoot - 512 balances 15.378 ms/op 16.793 ms/op 0.92
BeaconState.hashTreeRoot - 250000 balances 265.22 ms/op 290.93 ms/op 0.91
aggregationBits - 2048 els - zipIndexesInBitList 33.549 us/op 40.389 us/op 0.83
byteArrayEquals 32 80.415 ns/op 100.70 ns/op 0.80
Buffer.compare 32 59.172 ns/op 63.714 ns/op 0.93
byteArrayEquals 1024 2.2647 us/op 2.9356 us/op 0.77
Buffer.compare 1024 78.203 ns/op 83.786 ns/op 0.93
byteArrayEquals 16384 37.546 us/op 48.328 us/op 0.78
Buffer.compare 16384 300.60 ns/op 362.76 ns/op 0.83
byteArrayEquals 123687377 288.95 ms/op 282.61 ms/op 1.02
Buffer.compare 123687377 14.847 ms/op 13.236 ms/op 1.12
byteArrayEquals 32 - diff last byte 90.141 ns/op 88.181 ns/op 1.02
Buffer.compare 32 - diff last byte 64.961 ns/op 59.649 ns/op 1.09
byteArrayEquals 1024 - diff last byte 2.3416 us/op 2.3134 us/op 1.01
Buffer.compare 1024 - diff last byte 82.983 ns/op 75.882 ns/op 1.09
byteArrayEquals 16384 - diff last byte 37.352 us/op 34.882 us/op 1.07
Buffer.compare 16384 - diff last byte 315.38 ns/op 273.15 ns/op 1.15
byteArrayEquals 123687377 - diff last byte 277.98 ms/op 272.29 ms/op 1.02
Buffer.compare 123687377 - diff last byte 7.1734 ms/op 14.395 ms/op 0.50
byteArrayEquals 32 - random bytes 5.7420 ns/op 7.7490 ns/op 0.74
Buffer.compare 32 - random bytes 66.446 ns/op 71.358 ns/op 0.93
byteArrayEquals 1024 - random bytes 5.6970 ns/op 7.2910 ns/op 0.78
Buffer.compare 1024 - random bytes 65.691 ns/op 68.464 ns/op 0.96
byteArrayEquals 16384 - random bytes 6.4250 ns/op 7.6140 ns/op 0.84
Buffer.compare 16384 - random bytes 66.486 ns/op 64.269 ns/op 1.03
byteArrayEquals 123687377 - random bytes 9.4400 ns/op 20.720 ns/op 0.46
Buffer.compare 123687377 - random bytes 71.140 ns/op 78.180 ns/op 0.91
regular array get 100000 times 49.444 us/op 49.022 us/op 1.01
wrappedArray get 100000 times 49.398 us/op 48.163 us/op 1.03
arrayWithProxy get 100000 times 16.932 ms/op 14.971 ms/op 1.13
ssz.Root.equals 59.375 ns/op 59.143 ns/op 1.00
byteArrayEquals 59.694 ns/op 57.683 ns/op 1.03
Buffer.compare 12.612 ns/op 12.600 ns/op 1.00
shuffle list - 16384 els 7.5583 ms/op 7.3899 ms/op 1.02
shuffle list - 250000 els 110.43 ms/op 105.87 ms/op 1.04
processSlot - 1 slots 17.165 us/op 24.528 us/op 0.70
processSlot - 32 slots 3.0678 ms/op 4.3948 ms/op 0.70
getEffectiveBalanceIncrementsZeroInactive - 250000 vs - 7PWei 77.295 ms/op 64.569 ms/op 1.20
getCommitteeAssignments - req 1 vs - 250000 vc 3.9826 ms/op 2.7456 ms/op 1.45
getCommitteeAssignments - req 100 vs - 250000 vc 5.4081 ms/op 3.8540 ms/op 1.40
getCommitteeAssignments - req 1000 vs - 250000 vc 5.9176 ms/op 4.3222 ms/op 1.37
findModifiedValidators - 10000 modified validators 850.47 ms/op 690.19 ms/op 1.23
findModifiedValidators - 1000 modified validators 587.45 ms/op 468.11 ms/op 1.25
findModifiedValidators - 100 modified validators 659.41 ms/op 429.68 ms/op 1.53
findModifiedValidators - 10 modified validators 621.47 ms/op 439.48 ms/op 1.41
findModifiedValidators - 1 modified validators 462.08 ms/op 398.62 ms/op 1.16
findModifiedValidators - no difference 482.89 ms/op 387.44 ms/op 1.25
compare ViewDUs 5.3672 s/op 4.5391 s/op 1.18
compare each validator Uint8Array 1.7711 s/op 1.8600 s/op 0.95
compare ViewDU to Uint8Array 1.5688 s/op 1.3428 s/op 1.17
migrate state 1000000 validators, 24 modified, 0 new 848.48 ms/op 810.63 ms/op 1.05
migrate state 1000000 validators, 1700 modified, 1000 new 1.2411 s/op 1.1259 s/op 1.10
migrate state 1000000 validators, 3400 modified, 2000 new 1.4408 s/op 1.4266 s/op 1.01
migrate state 1500000 validators, 24 modified, 0 new 901.41 ms/op 858.91 ms/op 1.05
migrate state 1500000 validators, 1700 modified, 1000 new 1.1476 s/op 1.2651 s/op 0.91
migrate state 1500000 validators, 3400 modified, 2000 new 1.4710 s/op 2.1672 s/op 0.68
RootCache.getBlockRootAtSlot - 250000 vs - 7PWei 4.1300 ns/op 5.1900 ns/op 0.80
state getBlockRootAtSlot - 250000 vs - 7PWei 768.63 ns/op 886.56 ns/op 0.87
computeProposers - vc 250000 9.5948 ms/op 9.8855 ms/op 0.97
computeEpochShuffling - vc 250000 103.48 ms/op 112.09 ms/op 0.92
getNextSyncCommittee - vc 250000 157.99 ms/op 178.00 ms/op 0.89
computeSigningRoot for AttestationData 31.798 us/op 38.336 us/op 0.83
hash AttestationData serialized data then Buffer.toString(base64) 2.2364 us/op 2.4507 us/op 0.91
toHexString serialized data 1.0308 us/op 1.8042 us/op 0.57
Buffer.toString(base64) 205.28 ns/op 276.20 ns/op 0.74

by benchmarkbot/action

@wemeetagain
Copy link
Member

🎉 This PR is included in v1.14.0 🎉

ensi321 pushed a commit to ensi321/lodestar that referenced this pull request Jan 22, 2024
@matthewkeil @ensi321
fix: remove invalid workflow step (ChainSafe#6246)
7105172
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nflaig nflaig nflaig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matthewkeil @wemeetagain @nflaig