Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[automated] Update Lotus version in API tests #4866

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

LeshyBot
Copy link
Collaborator

@LeshyBot LeshyBot commented Oct 9, 2024

Changes

  • Updates Lotus version in the JSON-RPC API tests to the latest release.

@LeshyBot LeshyBot requested a review from a team as a code owner October 9, 2024 07:00
@LeshyBot LeshyBot requested review from hanabi1224 and LesnyRumcajs and removed request for a team October 9, 2024 07:00
@hanabi1224
Copy link
Contributor

Parity tests for Filecoin.StateMinerPreCommitDepositForPower is broken

2024-10-09T07:17:37.3037734Z Request dump: Request { method_name: "Filecoin.StateMinerPreCommitDepositForPower", params: Array [String("f0138097"), Object {"DealIDs": Null, "Expiration": Number(3055733), "SealProof": Number(8), "SealRandEpoch": Number(2004533), "SealedCID": Object {"/": String("bagboea4b5abcbp5d7ycbulzvf6ic73ab2zkeebeiasiyndbvpcl5zeqkk776uclm")}, "SectorNumber": Number(1990), "UnsealedCid": Null}, Array [Object {"/": String("bafy2bzaceaybqytxxdounajnsa7jgjtr4nkrzrlkdawoux2mgacpn6emeamas")}, Object {"/": String("bafy2bzacecqhuvzpreas6i5liaacfkp3wvrdcoqv4y5d4oggwxhhov4aq6cwe")}, Object {"/": String("bafy2bzaceaoeazbwlzzj55rzqm24chajk4x2wheksneshikm6yg4nqge56fmi")}, Object {"/": String("bafy2bzacecok4b4nj5mqwi2kgkrxfaetb7pdpdkliwqooy5ejcpdeaib557ua")}]], result_type: PhantomData<serde_json::value::Value>, api_paths: V1, timeout: 120s }
2024-10-09T07:17:37.3043281Z Request params JSON: ["f0138097",{"DealIDs":null,"Expiration":3055733,"SealProof":8,"SealRandEpoch":2004533,"SealedCID":{"/":"bagboea4b5abcbp5d7ycbulzvf6ic73ab2zkeebeiasiyndbvpcl5zeqkk776uclm"},"SectorNumber":1990,"UnsealedCid":null},[{"/":"bafy2bzaceaybqytxxdounajnsa7jgjtr4nkrzrlkdawoux2mgacpn6emeamas"},{"/":"bafy2bzacecqhuvzpreas6i5liaacfkp3wvrdcoqv4y5d4oggwxhhov4aq6cwe"},{"/":"bafy2bzaceaoeazbwlzzj55rzqm24chajk4x2wheksneshikm6yg4nqge56fmi"},{"/":"bafy2bzacecok4b4nj5mqwi2kgkrxfaetb7pdpdkliwqooy5ejcpdeaib557ua"}]]
2024-10-09T07:17:37.3047779Z Forest response: "343502843503823804794"
2024-10-09T07:17:37.3048942Z Lotus response: "34350284350382380479"
2024-10-09T07:17:37.3049691Z Diff: -"343502843503823804794"
2024-10-09T07:17:37.3050043Z 
2024-10-09T07:17:37.3050224Z +"34350284350382380479"
2024-10-09T07:17:37.3050514Z 
2024-10-09T07:17:37.3050521Z 
2024-10-09T07:17:37.3056918Z Request dump: Request { method_name: "Filecoin.StateMinerPreCommitDepositForPower", params: Array [String("f0138097"), Object {"DealIDs": Null, "Expiration": Number(3055733), "SealProof": Number(8), "SealRandEpoch": Number(2004533), "SealedCID": Object {"/": String("bagboea4b5abcbun7tqgnaiyq3sup5bb33zebqjlynkgrcbtoxg3sfn37ysc66bcd")}, "SectorNumber": Number(1989), "UnsealedCid": Null}, Array [Object {"/": String("bafy2bzacebba4hqc72yuuyziut43omsivdgzrfrvflmjyixyflzlknkkwibei")}, Object {"/": String("bafy2bzaceabdnjyoqte374ebwkfgyoq67yssfku26v6rmn5eipdtkuxcoslyg")}, Object {"/": String("bafy2bzacec3esagt4x4manbrvpczem67ssc5aqdojne5qzpfszoemme2hswkc")}]], result_type: PhantomData<serde_json::value::Value>, api_paths: V1, timeout: 120s }
2024-10-09T07:17:37.3066247Z Request params JSON: ["f0138097",{"DealIDs":null,"Expiration":3055733,"SealProof":8,"SealRandEpoch":2004533,"SealedCID":{"/":"bagboea4b5abcbun7tqgnaiyq3sup5bb33zebqjlynkgrcbtoxg3sfn37ysc66bcd"},"SectorNumber":1989,"UnsealedCid":null},[{"/":"bafy2bzacebba4hqc72yuuyziut43omsivdgzrfrvflmjyixyflzlknkkwibei"},{"/":"bafy2bzaceabdnjyoqte374ebwkfgyoq67yssfku26v6rmn5eipdtkuxcoslyg"},{"/":"bafy2bzacec3esagt4x4manbrvpczem67ssc5aqdojne5qzpfszoemme2hswkc"}]]
2024-10-09T07:17:37.3069781Z Forest response: "343502431473351305643"
2024-10-09T07:17:37.3070368Z Lotus response: "34350243147335130563"
2024-10-09T07:17:37.3071026Z Diff: -"343502431473351305643"
2024-10-09T07:17:37.3071354Z 
2024-10-09T07:17:37.3071508Z +"34350243147335130563"
2024-10-09T07:17:37.3071780Z 
2024-10-09T07:17:37.3071786Z 

@lemmih
Copy link
Contributor

lemmih commented Oct 9, 2024

Oof. Either there's a regression in Lotus, or they fixed a bug.

@LesnyRumcajs
Copy link
Member

@lemmih But you approved it! This means you volunteered to investigate it!

@lemmih
Copy link
Contributor

lemmih commented Oct 9, 2024

@lemmih But you approved it! This means you volunteered to investigate it!

I guess I brought that on myself.

@LesnyRumcajs
Copy link
Member

@lemmih It seems @LeshyBot "fixed" it. It's probably a particular event on the blockchain that triggered the issue and it would happen anyway. I believe the best course of action now is to upload the snapshot that fails the test and create an issue to investigate this behaviour.

@lemmih
Copy link
Contributor

lemmih commented Oct 10, 2024

Tracking issue: #4879

I will update the issue once the snapshot upload has finished.

@LesnyRumcajs LesnyRumcajs added this pull request to the merge queue Oct 10, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 10, 2024
@LesnyRumcajs LesnyRumcajs added this pull request to the merge queue Oct 10, 2024
Merged via the queue into main with commit 94dabc6 Oct 10, 2024
33 checks passed
@LesnyRumcajs LesnyRumcajs deleted the create-pull-request/patch branch October 10, 2024 14:59
LesnyRumcajs added a commit that referenced this pull request Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants