chore: easy-to-run docker compose setup for curio+forest #4848
Conversation
lemmih
requested review from
hanabi1224 and
sudo-shashank
and removed request for
a team
|
@lemmih WIP or no longer WIP? |
lemmih
changed the title
| ARG LOTUS_IMAGE | ||
| # hadolint ignore=DL3006 | ||
| FROM ${LOTUS_IMAGE} as lotus-test | ||
| FROM golang:1.22.3-bullseye AS curio-builder |
There was a problem hiding this comment.
How about using debian:bookworm and ubuntu:noble
There was a problem hiding this comment.
I'd like to keep it as similar to the "official" curio build environment as possible.
| ARG LOTUS_IMAGE | ||
| # hadolint ignore=DL3006 | ||
| FROM ${LOTUS_IMAGE} as lotus-test | ||
| FROM golang:1.22.3-bullseye AS curio-builder |
There was a problem hiding this comment.
| FROM golang:1.22.3-bullseye AS curio-builder | |
| FROM golang:1.22-bookworm AS curio-builder |
There was a problem hiding this comment.
The curio team uses golang:1.22.3-bullseye, so I hesitate to deviate. If bookworm is better, maybe we can upstream the change.
| RUN make build | ||
|
|
||
| ##################################### | ||
| FROM ubuntu:22.04 AS curio-all-in-one |
There was a problem hiding this comment.
| FROM ubuntu:22.04 AS curio-all-in-one | |
| FROM ubuntu:24.04 AS curio-all-in-one |
| ENV RUSTUP_HOME=/usr/local/rustup \ | ||
| CARGO_HOME=/usr/local/cargo \ | ||
| PATH=/usr/local/cargo/bin:$PATH \ | ||
| RUST_VERSION=1.63.0 |
There was a problem hiding this comment.
| RUST_VERSION=1.63.0 | |
| RUST_VERSION=1.73.0 |
There was a problem hiding this comment.
Good catch. Updated.
| @@ -0,0 +1,102 @@ | |||
| ##################################### | |||
There was a problem hiding this comment.
Is this built on every PR and subsequent commits? If so, it'd be better to save it, the same way we do with the Lotus Dockefiles.
There was a problem hiding this comment.
I'll change it to build on demand.
|
Will update the docker-compose file once our |
Summary of changes
Changes introduced in this pull request:
Reference issue to close (if applicable)
Closes
Other information and links
Change checklist