Fix ineffective concurrency lock (#70)

ChainSafe · Mar 11, 2024 · 1627403 · 1627403
1 parent abd30f2
commit 1627403
Showing 1 changed file with 16 additions and 12 deletions.
diff --git a/prover/src/rpc.rs b/prover/src/rpc.rs
@@ -65,12 +65,14 @@ where
     [(); S::SYNC_COMMITTEE_DEPTH]:,
     [(); S::FINALIZED_HEADER_INDEX]:,
 {
-    if let Err(e) = state.concurrency.clone().acquire_owned().await {
-        return Err(JsonRpcError::internal(format!(
-            "Failed to acquire concurrency lock: {}",
-            e
-        )));
-    };
+    let _permit = state
+        .concurrency
+        .clone()
+        .acquire_owned()
+        .await
+        .map_err(|e| {
+            JsonRpcError::internal(format!("Failed to acquire concurrency lock: {}", e))
+        })?;
 
     let GenProofCommitteeUpdateParams {
         light_client_update,
@@ -119,12 +121,14 @@ where
     [(); S::BYTES_PER_LOGS_BLOOM]:,
     [(); S::MAX_EXTRA_DATA_BYTES]:,
 {
-    if let Err(e) = state.concurrency.clone().acquire_owned().await {
-        return Err(JsonRpcError::internal(format!(
-            "Failed to acquire concurrency lock: {}",
-            e
-        )));
-    };
+    let _permit = state
+        .concurrency
+        .clone()
+        .acquire_owned()
+        .await
+        .map_err(|e| {
+            JsonRpcError::internal(format!("Failed to acquire concurrency lock: {}", e))
+        })?;
 
     let GenProofStepParams {
         light_client_finality_update,