Rename constant to what bridge relayers expect

[MRamanenkau]

Description

Types of Changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Dependency upgrade (A change in substrate or any 3rd party crate version)

Migrations and Hooks

• This change requires a runtime migration.
• Modifies on_initialize
• Modifies on_finalize

Checklist

• Change has been tested locally.
• Change adds / updates tests.
• Changelog doc updated.

[rakanalh]

You did not need to change all ChainId to ChainIdentity. You just needed to change the one declared as a constant in Config trait.

[MRamanenkau]

You did not need to change all ChainId to ChainIdentity. You just needed to change the one declared as a constant in Config trait.

The other code depends on ChainId not ChainIdentity so to fix the issue and make the code compiled we have 3 ways:

1. Extend Config with ChainIdentity and from the runtimes set the same value as ChainId.
2. Replace ChainId with ChainIdentity everywhere.
3. Try to find a way to set ChainIdentity derived from ChainId without passing from the runtimes.

In DM we agreed on option 2.

[MRamanenkau]

Moved to #237