-
Notifications
You must be signed in to change notification settings - Fork 330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENG-6266][ENG-6241] send monthly usage to trove as supplementary metadata #10764
[ENG-6266][ENG-6241] send monthly usage to trove as supplementary metadata #10764
Conversation
ee3e9d6
to
954dd0a
Compare
aa78756
to
2a473ec
Compare
osf_tests/metadata/expected_metadata_files/agent_supplementary.turtle
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In pair review, explored one rabbit-hole regarding efficiency/persistence of supplements. Once that's filled in, should be good to go 🐇
3ad5b6e
to
0235fe3
Compare
f3135b6
to
df1b9f3
Compare
(also clarify YearMonth method names and add tests)
- reduce redundance of view count computation - let "last month" be two months ago if last month isn't there yet
df1b9f3
to
b896b7e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎆 and left a few random questions out of curiosity.
(I love the unit tests coverage though I didn't go over them as carefully as the code).
2dd6052
into
CenterForOpenScience:feature/insti-dash-improv
Purpose
add monthly view counts to metadata indexed for search
Changes
is_supplementary
andexpiration_date
; see [ENG-6265] supplementary metadata SHARE#825 and [ENG-6313] allow raw data to expire SHARE#826 )osf.metadata.osf_gathering
) into three parts that are handled differently:OsfmapPartition.MAIN
is_supplementary
norexpiration_date
OsfmapPartition.SUPPLEMENT
is_supplementary
but withoutexpiration_date
OsfmapPartition.MONTHLY_SUPPLEMENT
is_supplementary
and anexpiration_date
two months after the reporting periodQA Notes
Please make verification statements inspired by your code and what your code touches.
What are the areas of risk?
Any concerns/considerations/questions that development raised?
Documentation
Side Effects
Ticket
ENG-6266