Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/addons service #10759

Conversation

brianjgeiger
Copy link
Collaborator

@brianjgeiger brianjgeiger commented Sep 20, 2024

Purpose

Merge develop into feature/addons-service

Changes

Mainly resolved merge conflicts in api_tests/users/views/test_user_addons.py - check for potential problems there.

mfraezz and others added 30 commits November 22, 2023 16:27
- Fix redirect
* add collection metadata options for ibdgc

---------

Co-authored-by: John Tordoff <>
Squashed commit of the following:

commit 5615a3a
Author: John Tordoff <>
Date:   Tue Dec 12 16:42:54 2023 -0500

    update is_triaged behavior

commit a9a49f2
Author: John Tordoff <>
Date:   Tue Dec 12 15:53:49 2023 -0500

    change test case to account for new exception handing for domain sniffer

commit 096e1ab
Author: John Tordoff <>
Date:   Tue Dec 12 14:03:25 2023 -0500

    redo exception handling and add migration file

commit 89b37f3
Author: John Tordoff <>
Date:   Mon Dec 11 12:13:31 2023 -0500

    make timeouts classify notable domains as unverified
* add collection metadata options for ibdgc

---------

Co-authored-by: John Tordoff <>
uditijmehta and others added 27 commits August 30, 2024 09:06
…async-email-502

Add logging to post-commit handlers
## Purpose

The preprint draft list includes deleted preprints, that's a litttle strange, lets fix that.

## Changes

- uses view query for filter out preprints that have been deleted
- adds test cases

Co-authored-by: John Tordoff <>
 * Something in python-upgrade started including the request input
   object in the headers. Celery/kombu can't serialize this and dies
   screaming. Silence the screams.

 [ENG-6022]
…ce/revert-10724-debug/async-email-502

Revert "Add logging to post-commit handlers"
…enScience#10728)

* fix thanks to MC, add working docker image
* use envvars consistently
* clean-up README.md

---------

Co-authored-by: John Tordoff <>
(Renamed feature/b-and-i-24-14 to feature/b-and-i-24-18)
Fix task name for clear_expired_sessions in celery schedule
…rOpenScience#10745)

[ENG-5829] Add Institutional Affiliation mix-in to Preprints CenterForOpenScience#10649
[ENG-5844] Add preprint institution affiliation endpoint CenterForOpenScience#10655
[ENG-5845] Preprint Institutions Relationship CenterForOpenScience#10659
[ENG-5846][ENG-5847] Add affiliated_institutions to preprint list and detail endpoint CenterForOpenScience#10684
[Bug-fix] Fix Self Link for Preprint Affiliated Institutions CenterForOpenScience#10698
[ENG-5908] Add Test Confirming Preprint Affiliated Institution Data is Sent to SHARE CenterForOpenScience#10700
[ENG-5966] 2.0.1 BE: Update permission to support edit as a WRITE contributor CenterForOpenScience#10741
[CR Response] Fix url links for PreprintsInstitutionsRelationshipSerializer and fix unit tests
Preprints Affiliation Project - BE Release
# Conflicts:
#	api_tests/users/views/test_user_addons.py
@brianjgeiger
Copy link
Collaborator Author

Hmmm, looks like we have some failing tests.

=================================== FAILURES ===================================
__ TestUserBitbucketAddon.test_account_detail_GET_returns_account_if_enabled ___
api_tests/users/views/test_user_addons.py:231: in test_account_detail_GET_returns_account_if_enabled
    assert addon_data['attributes']['provider'] == self.account.provider
E   KeyError: 'provider'
___ TestUserBitbucketAddon.test_account_list_GET_returns_accounts_if_present ___
api_tests/users/views/test_user_addons.py:160: in test_account_list_GET_returns_accounts_if_present
    assert addon_data['attributes']['provider'] == self.account.provider
E   KeyError: 'provider'
_____ TestUserBoxAddon.test_account_detail_GET_returns_account_if_enabled ______
api_tests/users/views/test_user_addons.py:231: in test_account_detail_GET_returns_account_if_enabled
    assert addon_data['attributes']['provider'] == self.account.provider
E   KeyError: 'provider'
______ TestUserBoxAddon.test_account_list_GET_returns_accounts_if_present ______
api_tests/users/views/test_user_addons.py:160: in test_account_list_GET_returns_accounts_if_present
    assert addon_data['attributes']['provider'] == self.account.provider
E   KeyError: 'provider'
__ TestUserDataverseAddon.test_account_detail_GET_returns_account_if_enabled ___
api_tests/users/views/test_user_addons.py:231: in test_account_detail_GET_returns_account_if_enabled
    assert addon_data['attributes']['provider'] == self.account.provider
E   KeyError: 'provider'
___ TestUserDataverseAddon.test_account_list_GET_returns_accounts_if_present ___
api_tests/users/views/test_user_addons.py:160: in test_account_list_GET_returns_accounts_if_present
    assert addon_data['attributes']['provider'] == self.account.provider
E   KeyError: 'provider'
___ TestUserDropboxAddon.test_account_detail_GET_returns_account_if_enabled ____
api_tests/users/views/test_user_addons.py:231: in test_account_detail_GET_returns_account_if_enabled
    assert addon_data['attributes']['provider'] == self.account.provider
E   KeyError: 'provider'
____ TestUserDropboxAddon.test_account_list_GET_returns_accounts_if_present ____
api_tests/users/views/test_user_addons.py:160: in test_account_list_GET_returns_accounts_if_present
    assert addon_data['attributes']['provider'] == self.account.provider
E   KeyError: 'provider'
____ TestUserGitHubAddon.test_account_detail_GET_returns_account_if_enabled ____
api_tests/users/views/test_user_addons.py:231: in test_account_detail_GET_returns_account_if_enabled
    assert addon_data['attributes']['provider'] == self.account.provider
E   KeyError: 'provider'
____ TestUserGitHubAddon.test_account_list_GET_returns_accounts_if_present _____
api_tests/users/views/test_user_addons.py:160: in test_account_list_GET_returns_accounts_if_present
    assert addon_data['attributes']['provider'] == self.account.provider
E   KeyError: 'provider'
_ TestUserGoogleDriveAddon.test_account_detail_GET_returns_account_if_enabled __
api_tests/users/views/test_user_addons.py:231: in test_account_detail_GET_returns_account_if_enabled
    assert addon_data['attributes']['provider'] == self.account.provider
E   KeyError: 'provider'
__ TestUserGoogleDriveAddon.test_account_list_GET_returns_accounts_if_present __
api_tests/users/views/test_user_addons.py:160: in test_account_list_GET_returns_accounts_if_present
    assert addon_data['attributes']['provider'] == self.account.provider
E   KeyError: 'provider'
___ TestUserMendeleyAddon.test_account_detail_GET_returns_account_if_enabled ___
api_tests/users/views/test_user_addons.py:231: in test_account_detail_GET_returns_account_if_enabled
    assert addon_data['attributes']['provider'] == self.account.provider
E   KeyError: 'provider'
___ TestUserMendeleyAddon.test_account_list_GET_returns_accounts_if_present ____
api_tests/users/views/test_user_addons.py:160: in test_account_list_GET_returns_accounts_if_present
    assert addon_data['attributes']['provider'] == self.account.provider
E   KeyError: 'provider'
______ TestUserS3Addon.test_account_detail_GET_returns_account_if_enabled ______
api_tests/users/views/test_user_addons.py:231: in test_account_detail_GET_returns_account_if_enabled
    assert addon_data['attributes']['provider'] == self.account.provider
E   KeyError: 'provider'
______ TestUserS3Addon.test_account_list_GET_returns_accounts_if_present _______
api_tests/users/views/test_user_addons.py:160: in test_account_list_GET_returns_accounts_if_present
    assert addon_data['attributes']['provider'] == self.account.provider
E   KeyError: 'provider'
____ TestUserZoteroAddon.test_account_detail_GET_returns_account_if_enabled ____
api_tests/users/views/test_user_addons.py:231: in test_account_detail_GET_returns_account_if_enabled
    assert addon_data['attributes']['provider'] == self.account.provider
E   KeyError: 'provider'
____ TestUserZoteroAddon.test_account_list_GET_returns_accounts_if_present _____
api_tests/users/views/test_user_addons.py:160: in test_account_list_GET_returns_accounts_if_present
    assert addon_data['attributes']['provider'] == self.account.provider
E   KeyError: 'provider'
___ TestUserOwnCloudAddon.test_account_detail_GET_returns_account_if_enabled ___
api_tests/users/views/test_user_addons.py:231: in test_account_detail_GET_returns_account_if_enabled
    assert addon_data['attributes']['provider'] == self.account.provider
E   KeyError: 'provider'
___ TestUserOwnCloudAddon.test_account_list_GET_returns_accounts_if_present ____
api_tests/users/views/test_user_addons.py:160: in test_account_list_GET_returns_accounts_if_present
    assert addon_data['attributes']['provider'] == self.account.provider
E   KeyError: 'provider'
=============================== warnings summary ===============================

@brianjgeiger brianjgeiger deleted the feature/addons_service branch October 2, 2024 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.