make it easier to run SHARE with OSF locally #10386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaxelb
force-pushed
the
quest/local-share
branch
2 times, most recently
from
453ef07
to
15ba09a
Compare
- remove osf:affiliatedInstitution (use osf:affiliation instead) - use dcterms:conformsTo to link osf registration schema - remodel funding info (add osf:hasFunding, osf:FundingAward)
- add osf:isPartOfCollection for osf-collection membership - express subjects as skos:Concept
aaxelb
force-pushed
the
quest/local-share
branch
from
ae1d489
to
56251ad
Compare
aaxelb
force-pushed
the
quest/local-share
branch
from
56251ad
to
e39d4c0
Compare
- use dcterms:Agent instead of osf:Agent - promote osf:funder to a top-level property (osf:hasFunding alongside)
- fix infinite redirect when setting up a provider with share - use `INTERNAL_DOMAIN` for provider assets (so SHARE can fetch an icon) - update docker-compose.yml to work with local SHARE
…#10051) * redirect rr to workflow and remove dead code. * consolidate routes and remove superfluous function --------- Co-authored-by: John Tordoff <>
aaxelb
force-pushed
the
quest/local-share
branch
from
e39d4c0
to
8cac5d0
Compare
aaxelb
changed the base branch from
develop
to
feature/search-improvements-2023
mfraezz
reviewed
Aug 8, 2023
| @@ -65,6 +80,11 @@ def add_arguments(self, parser): | |||
| action='store_true', | |||
| help='recatalog metadata for non-registration projects (and components)', | |||
| ) | |||
| # type_group.add_argument( | |||
There was a problem hiding this comment.
Should this have a comment as a future TODO, or did you mean to implement this behavior but haven't gotten to it yet?
There was a problem hiding this comment.
is a near-future TODO (someone made a ticket for it and everything)
once upon a time, sharev2 did not handle subtractive metadata updates. removing subjects from osf preprints became a very visible symptom of sharev2's limitation, and so yet another special case was added: hold "old subjects" after update so they can be included with "is_deleted" now, this is no longer necessary or helpful.
aaxelb
force-pushed
the
quest/local-share
branch
from
b65743c
to
ca772af
Compare
when building an index-card of metadata, include license and funding info for related osf objects (e.g. for a file's containing project)
mfraezz
merged commit f022e16
into
CenterForOpenScience:feature/search-improvements-2023
4 of 6 checks passed
mfraezz
pushed a commit
that referenced
this pull request
Aug 16, 2023
* Update metadata vocabularies * Support DataCite schema version 4.4 * Specify OSFMAP
mfraezz
pushed a commit
that referenced
this pull request
Aug 18, 2023
* Update metadata vocabularies * Support DataCite schema version 4.4 * Specify OSFMAP
mfraezz
added a commit
that referenced
this pull request
Aug 22, 2023
* OSFMAP Search Improvements (#10386) * [ENG-4618] User Search metadata (#10428) * [fixes] Search Improvement tests (#10432) * Fix Search Improvement test (#10435) * [Fix] Filterable "resourceNature" (#10434) * Add Withdrawal metadata to SHARE (#10430) * [ENG-4617] Send File Metadata to SHARE (#10436) * Fix: Skip sending non-provider collections to SHARE (#10439) * Optimize recatalog_metadata via celery (#10440) * fix: send utf-8 to shtrove (#10437) * [fix] Search/Metadata back-compat and fixes (#10443) * [fix] Add missing registration component metadata (#10444) * d42708e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(note: includes #10385 )
Purpose
make it easier to run SHARE with OSF locally
try it out with CenterForOpenScience/SHARE#806 (see the share quickstart doc for setting it up locally)
(using local SHARE with the registries discover page depends on CenterForOpenScience/ember-osf-web#1849 )
Changes
INTERNAL_DOMAINfor provider assets (so SHARE can fetch an icon)QA Notes
Please make verification statements inspired by your code and what your code touches.
What are the areas of risk?
Any concerns/considerations/questions that development raised?
Documentation
Side Effects
Ticket