Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm currently working with an STM32 S3 board and I've run into a number of problems, including the lack of APLL support on the I2S interface.
I2S_CLK_SRC_APLL
is hard-coded:snapclient/components/lightsnapcast/player.c
Line 255 in f52f436
adjust_apll()
callsrtc_clk_apll_coeff_set()
which does not exist in my setup, breaking compilation:snapclient/components/lightsnapcast/player.c
Line 821 in f52f436
I've implemented a working solution by replacing
CONFIG_USE_SAMPLE_INSERTION
withCONFIG_USE_APLL
.Doing it this way defaults to a "safe" configuration, and only gives you the option if the underlying hardware supports the feature.
sdkconfig
would not be backwards-compatible - I'm not sure if that's a dealbreaker.