-
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Programatic SEO #108
Conversation
✅ Deploy Preview for capgo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Can you take a look at https://deploy-preview-108--capgo.netlify.app/plugins/ and let me know if any changes with icons/design are required? I'll then take on the each page for each plugin. |
Very nice! Maybe there some to exclude but that cool 👍 |
What do you mean by exclude? Where can I gather what to exclude? |
I'm updating the code with a bearer token env (GITHUB_BEARER_TOKEN) that's required to fetch stars & readme from GitHub. Let me know if there's another way to get around this. |
@riderx This is ready for review. You'd still need to add your env of BEARER_TOKEN to the git repo (or wherever pnpm build gets executed) |
@rishi-raj-jain thanks a lot, can you share what rights i should but in the token ? |
For the plugin page we need more content we look for SEO here, so we need to use the REAME file to create automatic content. like plugin presentation and tutorial made with gpt for example |
Hey @riderx, You can create a classic GitHub token, and no need to select any checkbox there, we just need the API key to be able to fetch public repository worldwide. |
Hey @riderx,
|
i just added the token in github and netlify |
I think we should create all of that statically instead of doing real time as this'd require both open ai key and GitHub api key, that can rate limit given the number of PRs and build process that kicks in for each commit. |
Named BEARER_TOKEN, right? |
i thnk it's ok for now like that, |
and then i accept it :) |
Ok if you want to try gpt I think you can create a script to make it and we can run it separately or in the CI. |
It's doable in CI context or need more ? |
How I imagine is this:
This'll allow you to not call the API whenever PRs are deployed via Netlify in Pull Requests, and can choose to run that only on the main branch. |
I think the tutorials look awesome now on the plugins pages. Note: I've updated the CI/CD to generate the tutorials, and dynamically get deployed with each build. In case of any errors in generation with any of them is found, the ones that you see right now will be used. I believe this is ready for review. Make sure you've OPENAI_API_KEY & BEARER_TOKEN set in the your CI. |
I have add OPENAI_API_KEY and restarted the deploy, let's see :) |
The generation is very good, just the design has issue on the deployed version i see the readme and then the tutorial, maybe let's do tabs to switch between readme and tuto |
I'm super glad that you love it! On the way to tabs. |
it seems the text is not finished here: https://deploy-preview-108--capgo.netlify.app/plugins/capgo-cli/ |
Kudos, SonarCloud Quality Gate passed! |
The cool thing about the plugin page is everything is server side rendered! Both the tuto and the readme. This'd help in SEO as you expected/wanted to have. |
fix #107
/claim #107