Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial slide fixes for ICCS summer school 24 #64

Merged
merged 5 commits into from
Jul 1, 2024
Merged

Initial slide fixes for ICCS summer school 24 #64

merged 5 commits into from
Jul 1, 2024

Conversation

ma595
Copy link
Collaborator

@ma595 ma595 commented Jun 26, 2024

This PR fixes minimal aspects of the workshop's accompanying slides in readiness for the 2024 edition of the ICCS summer school. There is scope to add more.

I have added Surbhi and I as additional authors. I would like to emphasise that we are teaching the session, if possible. @jatkinson1000 do you you have any formatting suggestions?

  • Fix the parameter update rule. See https://en.wikipedia.org/wiki/Stochastic_gradient_descent
  • Various spelling and style changes
  • Modify names of presenters, and acknowledge Jim and Jack.
  • Create 'material' slide that points to github link and cites Jack and Jim's code and JOSE paper.
  • Amend contact with two additional columns.

Closes part of #61

@ma595 ma595 self-assigned this Jun 26, 2024
@ma595 ma595 marked this pull request as draft June 26, 2024 20:09
Copy link
Member

@jatkinson1000 jatkinson1000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All seem sensible.

One comment is to drop the 'AZ' from @jdenholm's affiliation and make him UoC or something, as I know they are picky about what their name appears on.

@ma595
Copy link
Collaborator Author

ma595 commented Jun 26, 2024

Any suggestions on how to make the actual speakers' names stand out on the title page? i.e. with some quarto emphasis effect? I wasn't able to figure this out quickly.

@ma595 ma595 marked this pull request as ready for review June 27, 2024 08:49
@ma595 ma595 requested a review from jatkinson1000 June 27, 2024 08:49
Copy link
Member

@jatkinson1000 jatkinson1000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good from me.

Regarding the formatting question - my suggestion would be to put yourself and Surbhi on the title slide to make it clear who is teaching.

What you could do is put a note on the subsequent slide with license and repo links etc to say it is based on the workshop developed by Jim and I. If you could also add a citation to the JOSE paper there that would be wonderful.

I will approve the PR now, as this is not a critical blocker, but that change would be appreciated :)

Copy link

@surbhigoel77 surbhigoel77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ma595
Copy link
Collaborator Author

ma595 commented Jun 27, 2024

LGTM

I'll attempt to address Jack's comments first.

@ma595 ma595 merged commit 2a379bf into main Jul 1, 2024
2 checks passed
@ma595 ma595 deleted the slide-fixes branch July 5, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants