Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

46 fix regression tests file contents #47

Draft
wants to merge 18 commits into
base: ustar_cp_refactor_main
Choose a base branch
from

Conversation

j-emberton
Copy link
Member

@j-emberton j-emberton commented Nov 5, 2024

closes #46

Fixes the issue where regression test reference data is incorrect.

Following update of the data it appears that two of the regression tests do not pass - US-Syv and (another, to be filled in).

If you run the code so that the regression tests try to use the old code, the regression tests fail. This is because they cannot find the keyword 'processing' in the report_*.txt output file which summarises the processing of all the files associated with a specific case.

The causes of the regression tests failing for our new code could include:

  1. The reference test data is incorrect somehow i.e. comes from a different code version
  2. We have made inadvertent changes to the code behaviour that are detected by the tests
  3. Changes to how specific matlab functions behave between 2018 and 2024

The cause of the regression tests failing for the old code could include:

  1. incorrect setup of matlab engine for old code case

To investigate this further we can try running the compiled matlab code with the MCR and a specific set of test data to compare the output with what we expect and what our code delivers. This should give us good insight into what's going on.

There is a readme in oneflux/oneflux_steps/ustar_cp/bin which details running in standalone mode on linux.

@j-emberton j-emberton self-assigned this Nov 5, 2024
@tztsai tztsai self-assigned this Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants