forked from fluxnet/ONEFlux
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
46 fix regression tests file contents #47
Draft
j-emberton
wants to merge
18
commits into
ustar_cp_refactor_main
Choose a base branch
from
46-fix-regression-tests-file-contents
base: ustar_cp_refactor_main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
46 fix regression tests file contents #47
j-emberton
wants to merge
18
commits into
ustar_cp_refactor_main
from
46-fix-regression-tests-file-contents
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/ONEFlux into 37-modularise-cpdBoostrap
Change matlab_engine scope to 'session'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #46
Fixes the issue where regression test reference data is incorrect.
Following update of the data it appears that two of the regression tests do not pass - US-Syv and (another, to be filled in).
If you run the code so that the regression tests try to use the old code, the regression tests fail. This is because they cannot find the keyword 'processing' in the
report_*.txt
output file which summarises the processing of all the files associated with a specific case.The causes of the regression tests failing for our new code could include:
The cause of the regression tests failing for the old code could include:
To investigate this further we can try running the compiled matlab code with the MCR and a specific set of test data to compare the output with what we expect and what our code delivers. This should give us good insight into what's going on.
There is a readme in
oneflux/oneflux_steps/ustar_cp/bin
which details running in standalone mode on linux.