Refactor launch file [WIP] #34
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passes all current tests
All tests passed
All tests passed
All tests pass
…ving PPFD columns All tests pass
All tests passed
dorchard
reviewed
Sep 19, 2024
Comment on lines
+183
to
+210
| function [input_folder, output_folder] = check_path(input_folder, output_folder) | ||
|
|
||
| % check input path | ||
| if 0 == exist('input_folder') | ||
| input_folder = [pwd '/']; | ||
| elseif length(input_folder) < 2 | ||
| if input_folder(2) ~= ':' | ||
| input_folder = [pwd '/' input_folder]; | ||
| end | ||
| end | ||
| if input_folder(length(input_folder)) ~= '\' && input_folder(length(input_folder)) ~= '/' | ||
| input_folder = [input_folder '/']; | ||
| end | ||
| end | ||
| if output_folder(length(output_folder)) ~= '\' && output_folder(length(output_folder)) ~= '/' | ||
| output_folder = [output_folder '/']; | ||
| end | ||
| mkdir(output_folder); | ||
|
|
||
| %by alessio | ||
| USTAR_INDEX = 1; | ||
| NEE_INDEX = 2; | ||
| TA_INDEX = 3; | ||
| PPFD_INDEX = 4; | ||
| RG_INDEX = 5; | ||
| input_columns_names = {'USTAR' 'NEE' 'TA' 'PPFD_IN' 'SW_IN' }; | ||
| % check output path | ||
| if 0 == exist('output_folder') | ||
| output_folder = [pwd '/']; | ||
| elseif length(output_folder) < 2 | ||
| if output_folder(2) ~= ':' | ||
| output_folder = [pwd '/' output_folder]; | ||
| end | ||
| end | ||
| if output_folder(length(output_folder)) ~= '\' && output_folder(length(output_folder)) ~= '/' | ||
| output_folder = [output_folder '/']; | ||
| end | ||
| mkdir(output_folder); | ||
|
|
||
| %by alessio | ||
| fprintf('\n\nUstar Threshold Computation by Alan Barr\n\ninput in %s\noutput in %s\n\n', input_folder, output_folder); | ||
| d = dir([input_folder,'*_qca_ustar_*.csv']); | ||
| error_str = {}; | ||
| end |
There was a problem hiding this comment.
I think that there is a single function for checking a path which could be extracted from this and reused (the code looks the same between checking input and output paths)
| dataset = textscan(fid,'%[^\n]');dataset = dataset{1}; | ||
|
|
||
| function [exitcode, site, year, lat, lon, timezone, htower, timeres, sc_negl, notes] ... | ||
| = not_valid_header(dataset) |
There was a problem hiding this comment.
Nice - definitely makes sense to split this out and then I think we can abstract this and replace a lot of repetition
|
We decided to build on this PR with the rest of the refactoring and testing. @isaacaka to add a checklist of the items in the PR first post. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First pass on refactoring launch.m. Split the single big main function into multiple sub-functions which are then called by the main function.
Closes #26