-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create test_cpdAssignUStarTh20100901.m #28
base: 37-modularise-cpdBoostrap
Are you sure you want to change the base?
Create test_cpdAssignUStarTh20100901.m #28
Conversation
Quite a few of the tests fail for me. Some seem to be to do with the creating of a struct to pass to MATLAB:
Others seem to be to do with the matlab engine setup. I can't see why this would be a local problem for me in the latter case. |
tests/unit_tests/test_ustar_cp/test_cpdAssignUStarTh20100901.py
Outdated
Show resolved
Hide resolved
tests/unit_tests/test_ustar_cp/test_cpdAssignUStarTh20100901.py
Outdated
Show resolved
Hide resolved
tests/unit_tests/test_ustar_cp/test_cpdAssignUStarTh20100901.py
Outdated
Show resolved
Hide resolved
tests/unit_tests/test_ustar_cp/test_cpdAssignUStarTh20100901.py
Outdated
Show resolved
Hide resolved
3532819
to
3066924
Compare
…20100901.py Co-authored-by: James Emberton <[email protected]>
e3983df
to
7b0b7f7
Compare
Thanks @tztsai - I'm having a problem with the tests here |
I think I've narrowed it down to tests/unit_tests/test_ustar_cp/test_cpdBootstrapUStarTh4Season20100901.py on line 143... which is strange. |
Now the handling of NaN and None values and their comparison are fixed. All tests pass. |
@tztsai Thanks! looks good to me. Could you resolve the conflicts with the target branch then I am happy to approve for merge. |
…for-cpdassignustar
Resolved now |
Closes #27
Added unit tests for
cpdAssignUStarTh20100901
and updatedconftest.py
with aMFWrapper
to wrap the matlab function. WithMFWrapper
, any function call bymatlab_engine.FUNC
will automatically handle the JSON encoding and decoding of non-scalar structs, as long as in the Python side we add keyword argumentsjsonencode=[...]
orjsondecode=[...]
tomatlab_engine.FUNC()
. The wrapper also will show the printing in MATLAB functions at the end of the testing.