Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests framework #2

Draft
wants to merge 43 commits into
base: main
Choose a base branch
from
Draft

Tests framework #2

wants to merge 43 commits into from

Conversation

ma595
Copy link
Member

@ma595 ma595 commented Jan 27, 2023

No description provided.

@ARibecaJob
added extern to fix compilation on gcc 10
ce29e87
@ARibecaJob
bugfixes:
4ddd4a3 
- do not compute NEE if FC entirely NULL
- do not put NEE on file if FC missing or entirely NULL
- do not create U* file if U*, NEE or FC are missing or entirely invalid
- do not create ENERGY file if H or LE missing or entirely invalid
@ARibecaJob
bugfixes:
c33b1b3 
- fixed bug on quality flags for gapfilled LE and H. Correctly calculate the QC value in case of missing data
- renamed vars from SW_IN_M, SW_IN_mqc to SW_IN_m, SW_IN_mqc
- fixed: changing the value of the QC to -9999 when it was not possible to calculate the energy balance and create the LE_Corr. It is also a "known issue" in FLUXNET2015 release
- cosmetic fixes
@ARibecaJob
- added comments regarding U* filtering
2fd94e5 
- added disabled refactored code (disabled to maintain consistency)
@ARibecaJob
general:
a00becb 
+ added vc++ 2008 solution (was missing!)
+ created Makefile for gf_mds
- removed common_pi.c (not used)

common:
# changed internal defines \ enums \struct for new gf_mds code
# some funcs now using timeres enum instead of hourly bool var
# gf_mds is now an unique func and it has new parameters (QC thresholds, symmetrical mean, max MDV window, ...)
- removed gf_mds_with_qc, gf_mds_with_bounds, temp_gf_mds (see above)
+ added some new funcs: get_rows_count_by_timeres, check_timestamp, timestamp_difference_in_seconds
# mystrcat renamed in string_concat

qc_auto:
# upgraded to v1.01
# minor fixes to reflect changes in common func

ustar_mp:
# upgraded to v1.01
# minor fixes to reflect changes in common func

meteo_proc:
# upgraded to v1.01
# minor fixes to reflect changes in common func

nee_proc:
# upgraded to v1.01
# minor fixes to reflect changes in common func

energy_proc:
# upgraded to v1.01
# minor fixes to reflect changes in common func

gf_mds:
# upgraded to v3.0
# big fixes to reflect changes in common func
# now using "driver" instead of fluxes name
+ each driver now has a min and max tolerance customizable value
+ added driver QC threshold change
+ added symmentrical mean computation
+ added max MDV window parameter

SW_IN_POT_Calculator:
# upgraded to v1.01
# minor fixes to reflect changes in common func

shift_solar_noon:
# upgraded to v1.01
# minor fixes to reflect changes in common func

ure:
# upgraded to v1.01
# minor fixes to reflect changes in common funcs
@ARibecaJob
common:
9c30650 
# fixed gf computation
# changed comments

qc_auto:
# replaced 'founded' with 'found'

meteo_proc:
# replaced 'founded' with 'found'

nee_proc:
# fixed meteo import
# fixed outputs computation
# memory will be freed per site to prevent out of memory
# replaced 'founded' with 'found'

energy_proc:
# fixed meteo import
# fixed outputs computation
# replaced 'founded' with 'found'

ure:
# replaced 'founded' with 'found'

ustar_mp:
# replaced 'founded' with 'found'
@ARibecaJob
+ added explanation comments at beginning of main.c file to following…
62dbfea 
… tools:

qc_auto
ustar_mp
meteo_proc
nee_proc
energy_proc
gf_mds
SW_IN_POT_Calculator
shift_solar_noon
ure
@ma595 ma595 marked this pull request as draft January 30, 2023 11:07
ARibecaJob and others added 22 commits April 7, 2023 16:14
@ARibecaJob
C unit testing with utest.h library
90d3ab7
@ARibecaJob
general:
11c1811 
+ added vc++ 2008 solution (was missing!)
+ created Makefile for gf_mds
- removed common_pi.c (not used)

common:
# changed internal defines \ enums \struct for new gf_mds code
# some funcs now using timeres enum instead of hourly bool var
# gf_mds is now an unique func and it has new parameters (QC thresholds, symmetrical mean, max MDV window, ...)
- removed gf_mds_with_qc, gf_mds_with_bounds, temp_gf_mds (see above)
+ added some new funcs: get_rows_count_by_timeres, check_timestamp, timestamp_difference_in_seconds
# mystrcat renamed in string_concat

qc_auto:
# upgraded to v1.01
# minor fixes to reflect changes in common func

ustar_mp:
# upgraded to v1.01
# minor fixes to reflect changes in common func

meteo_proc:
# upgraded to v1.01
# minor fixes to reflect changes in common func

nee_proc:
# upgraded to v1.01
# minor fixes to reflect changes in common func

energy_proc:
# upgraded to v1.01
# minor fixes to reflect changes in common func

gf_mds:
# upgraded to v3.0
# big fixes to reflect changes in common func
# now using "driver" instead of fluxes name
+ each driver now has a min and max tolerance customizable value
+ added driver QC threshold change
+ added symmentrical mean computation
+ added max MDV window parameter

SW_IN_POT_Calculator:
# upgraded to v1.01
# minor fixes to reflect changes in common func

shift_solar_noon:
# upgraded to v1.01
# minor fixes to reflect changes in common func

ure:
# upgraded to v1.01
# minor fixes to reflect changes in common funcs
@ARibecaJob
common:
4dec94d 
# fixed gf computation
# changed comments

qc_auto:
# replaced 'founded' with 'found'

meteo_proc:
# replaced 'founded' with 'found'

nee_proc:
# fixed meteo import
# fixed outputs computation
# memory will be freed per site to prevent out of memory
# replaced 'founded' with 'found'

energy_proc:
# fixed meteo import
# fixed outputs computation
# replaced 'founded' with 'found'

ure:
# replaced 'founded' with 'found'

ustar_mp:
# replaced 'founded' with 'found'
@ARibecaJob
+ added explanation comments at beginning of main.c file to following…
75e4efd 
… tools:

qc_auto
ustar_mp
meteo_proc
nee_proc
energy_proc
gf_mds
SW_IN_POT_Calculator
shift_solar_noon
ure
@isaacaka
Added missing parameters required to run program on the example data
50743f3
@ARibecaJob
meteo_proc:
5fc4d2b 
# fixed bug that occurs when TS and SWC columns have non-sequential or missing profiles
@gilbertozp
Merge pull request #27 from ARibecaJob/24-update-c-code-base-to-compl…
949b4d2 
…y-with-new-enforcement-of-single-declaration-of-universal-variables

Fixing compilation issues with newer versions of GCC
@gilbertozp
Merge pull request #35 from ARibecaJob/energy_proc_flags_bugfixes
0e125fd 
energy_proc quality flags bugfixes:
@gilbertozp
Merge pull request #34 from ARibecaJob/qc_auto_bugfixes
7ea7d31 
qc_auto bugfixes
@gilbertozp
Merge pull request #36 from ARibecaJob/nee_proc_comments
ce033a7 
Added new mode for locating string with faster mode of execution for nee_proc
@gilbertozp
Merge branch 'main' into gap_filling
db65165
@gilbertozp
add details on required data/metadata
f6fd4a4
@gilbertozp
add header for citation
a7d6ad5
@gilbertozp
move citation info location
57f25a9
@gilbertozp
change spacing and breakline
e602687
@gilbertozp
fiz horizontal line
7073bfc
@gilbertozp
Merge pull request fluxnet#63 from gilbertozp/add-required-vars
ec1d2f4 
Add required vars to description
@gilbertozp
Merge pull request fluxnet#52 from ARibecaJob/gap_filling
b9cd01a 
Adjust MDS to support additional parameters
@gilbertozp
Merge branch 'main' into main
10ab672
@gilbertozp
Fix incorrect conflict resolution to dataset.c
9342540 
Previous commit had not fixed conflict resolution, only preserved automated Github annotations
@gilbertozp
Merge pull request fluxnet#59 from ARibecaJob/main
ea6c56e 
Fixed bug on meteo_proc
@gilbertozp
apply patch from Alessio to ure/dataset.c for timestamp handling
0efcc0d
gilbertozp and others added 8 commits September 10, 2024 18:01
@gilbertozp
Merge pull request fluxnet#64 from gilbertozp/add-ure-patch
11ed032 
Apply patch from Alessio to ure/dataset.c for timestamp handling. This patch was pending from previous merges from PR#52 and PR#59. All tests results comparable to PR#59 as expected.
@isaacaka @dorchard
Update README.md
ddc7d49 
Remove reference to issue

Co-authored-by: Dominic Orchard <[email protected]>
@isaacaka @dorchard
Update README.md
8a7e3ad 
Remove reference to issue

Co-authored-by: Dominic Orchard <[email protected]>
@isaacaka
Update README.md
f02ade6
@isaacaka
Update README.md
b653abc 
--era-fy and --era-ly not needed here
@gilbertozp
Update version to 0.5.05-rc
919dcef
@gilbertozp
Merge pull request fluxnet#69 from fluxnet/update-version-0.5.0-rc
84709b7 
Update version to 0.5.05-rc
@gilbertozp
Merge pull request fluxnet#58 from Cambridge-ICCS/update_readme
af0e985 
Added missing parameters required (and docs) to run program on the sample data
@ma595 ma595 force-pushed the tests_framework branch 3 times, most recently from 4b2d6ae to a98c3e4 Compare October 18, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ma595 @ARibecaJob @isaacaka @gilbertozp