Fix piecewise hazard prediction #1268
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -2873,7 +2873,7 @@ def test_efron_newtons_method(self, data_nus, cph): | |||
| assert np.abs(newton(X, T, E, W, entries)[0] - -0.0335) < 0.0001 | |||
|
|
|||
|
|
|||
| class TestCoxPHFitterPeices: | |||
| class TestCoxPHFitterPieces: | |||
|
The code look reasonable, and I can't spot a problem by looking at it. I'm going to pull this locally to see if I can figure it out. BTW - this specific code, the cumulative hazard function for piecewise-whatever, is very complex (and lacking comments - thanks @CamDavidsonPilon...), and I am surprised you were not scared off by it. |
|
Also PR workflow is perfect |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The unit test test_estimation / TestCoxPHFitterPieces.test_predict_hazard_sans_strata fails, where i am comparing the result of predicting hazard for 1 of 5 samples to the 1 sample run by itself. This seems to be because running egrad on a matrix input isn't what we want to do (we just want to differentiate cumulative hazard along time axis). Not sure how to fix it though.
Ignore the change to pre-commit hook for the moment. It's the only way i could seem to commit files. black throws an error message i can't resolve if i leave it there. Can figure this out later...